<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>I found where this code is used: Writer -> Insert -> Indexes and Tables -> Indexes and Tables -> Entries.</div><div><br></div><div>Currently I can't build due to a non-related issue so I can't trouble shoot it. My git foo is also bad enough that I can't figure out how to remove it...</div><div><br></div><div>Needless to say, my patch causes a SegFault when every the tab is selected. Can I get someone to remove the patch; I need to fix it and I don't want people having issues until then.</div><div><br></div><div>Thanks,</div><div><br></div><div>Joe P.</div><div><br></div><br><div><div>On Dec 12, 2010, at 9:35 PM, Joseph Powers wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">The patch for <span class="Apple-style-span" style="font-family: Arial; font-size: 12px; ">DECLARE_LIST( SwXMLFrmFmts_Impl, SwFrmFmtPtr ) was really easy so I pushed it...</span><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">However, long story short, I also ended up pushing this patch. If anyone has any issues, it can be reverted.</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">I'm sorry for the confusion.</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">Joe P.</font></div><div><font class="Apple-style-span" face="Arial"><br></font><div><div>On Dec 12, 2010, at 8:26 PM, Joseph Powers wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>TOXControlList is used more like a list<> then a vector<>; however, the code was written using mostly [] style accessors. Thus, I had to rewrite a lot of control logic and would like someone else to review it before it gets installed.</div><div><br></div><div>Two methods where looping through the list list.size() times. Looking at the code, I couldn't determine why this had to be done so I changed the code to only process the list once. The methods are:</div><div><br></div><div>IMPL_LINK(SwTokenWindow, TbxFocusHdl, SwTOXEdit*, pEdit)</div><div>IMPL_LINK(SwTokenWindow, TbxFocusBtnHdl, SwTOXButton*, pBtn )</div><div><br></div><div>I played around in writer a little bit but couldn't figure out where this code was being used. If someone could point me in the right direction, I'll do a little more testing.</div><div><br></div><div><br></div></div><span><0001-Remove-DECLARE_LIST-TOXControlList-Control.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div><div><br></div><div>------------------------------------------------------------------------------------</div><div><br></div><div>I'm having some issues removing <span class="Apple-style-span" style="font-family: Arial; font-size: 12px; ">DECLARE_LIST( SwXMLTableLinesCache_Impl, SwXMLTableLinesPtr ) from </span><span class="Apple-style-span" style="font-family: Arial; font-size: 12px; ">sw/source/filter/xml/xmltble.cxx.</span></div><div><span class="Apple-style-span" style="font-family: Arial; font-size: 12px; "><br></span></div><div><span class="Apple-style-span" style="font-family: Arial; font-size: 12px; ">The main issue is that my compiler (g++ 4.0) doesn't allow the following:</span></div><div><span class="Apple-style-span" style="font-family: Arial; font-size: 12px; "><br></span></div><div><span class="Apple-style-span" style="font-family: Arial; font-size: 12px; ">class Foo;</span></div><div><span class="Apple-style-span" style="font-family: Arial; font-size: 12px; "><br></span></div><div><span class="Apple-style-span" style="font-family: Arial; font-size: 12px; ">class Bar {</span></div><div><span class="Apple-style-span" style="font-family: Arial; font-size: 12px; "><span class="Apple-tab-span" style="white-space:pre"> </span>Foo* myFoo;</span></div><div><font class="Apple-style-span" face="Arial">}</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">class Foo {</font></div><div><font class="Apple-style-span" face="Arial"><span class="Apple-tab-span" style="white-space:pre"> </span>int mySomething;</font></div><div><font class="Apple-style-span" face="Arial">}</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">typedef ::std::vector< Foo* > typeFoo;</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">Because of this, I need to move enough information from the .cxx into .hxx to define Foo before Bar; however, Foo is build using some more magic Macros so I don't know how much code I can safely move to the header. Any suggestions on this would be nice.</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">The only two DECLARE_LIST() instances left in writer are the above and </font><span class="Apple-style-span" style="font-family: Arial; font-size: 12px; ">DECLARE_LIST( SwXMLFrmFmts_Impl, SwFrmFmtPtr ) which is declared in the same .cxx as the one problem one. I'm going to see if it has the same issue.</span></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">Thanks for your help,</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">Joe P.</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div></div></blockquote></div><br></div></div></blockquote></div><br></body></html>