Hello Kohei,<br><br>Thanks for making the improvements.<br><br>> I haven't found a way to change the color of edit box either, so we can<br>
> leave that a future project for now.<br>
<br>Setting the background color is what I have used for the warning label:<br>"aFtWarn.SetControlBackground( Color( COL_YELLOW ) );"<br>I suppose something simular can be used for the edit box, if you want that.<br>
<br>Joost<br><br><br><div class="gmail_quote">2011/1/3 Kohei Yoshida <span dir="ltr"><<a href="mailto:kyoshida@novell.com">kyoshida@novell.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hello Joost,<br>
<div class="im"><br>
On Tue, 2010-12-28 at 16:45 +0100, Joost Eekhoorn wrote:<br>
> Hoi Kohei and all,<br>
><br>
> I hope you enjoy the lovely weather.<br>
><br>
> Hereby a patch to give a better user experience to the "Move/Copy<br>
> sheet" dialog.<br>
><br>
> The changes are:<br>
> - Removed the "Rename"checkbox.<br>
> The "New name" textfield is always available, when one sheet is<br>
> selected.<br>
> It is disabled, when multiple sheets are selected.<br>
> - "OK", "Cancel" and "Help" buttons placed at the bottom of the<br>
> dialog.<br>
> - "Copy" checkbox replaced by "Copy" and "Move" option buttons.<br>
> - Added 3 section headers: "Action", "Location" and "Name".<br>
> - Placed the text "(Current document)" behind the name<br>
> of the of the current document in the list "To document".<br>
> - Display the yellow warning " ! This name is already used", when<br>
> applicable.<br>
<br>
</div>This all looks good. Once again, I've taken the liberty of making some<br>
follow-up modifications after your patch. I basically did:<br>
<br>
* adjusted the dialog layout a bit to make it look more consistent &<br>
make better use of available spaces if possible. With this, the list<br>
box etc are little wider.<br>
<br>
* added three different warning messages for different causes: 1) name<br>
already used, 2) name is empty, and 3) name has invalid characters.<br>
<br>
* disable the OK button when the new name is invalid.<br>
<div class="im"><br>
> I did not know a better way to display the warning (I searched several<br>
> hours.)<br>
<br>
</div>I think the way you did it is sufficient; but I'd like us to eventually<br>
find a way to turn the background of the sheet name box pink (or light<br>
red, whatever the actual color is) the same way the chart dialogs do<br>
while the background color of the warning text stays transparent. IMO<br>
that would fit a little better and more consistent with the rest of our<br>
UI.<br>
<br>
I haven't found a way to change the color of edit box either, so we can<br>
leave that a future project for now.<br>
<div class="im"><br>
> I did not changed the "Insert before" listbox.<br>
<br>
</div>I think it's best if we leave this alone for now. We'll probably come<br>
back to it later.<br>
<div class="im"><br>
> I do not display the current sheet name.<br>
<br>
</div>I assume you mean displaying the current sheet name in the title bar of<br>
the dialog box. Yeah we'll leave this a future project too.<br>
<br>
Thanks a lot for your patch. :-)<br>
<br>
Kohei<br>
<font color="#888888"><br>
--<br>
Kohei Yoshida, LibreOffice hacker, Calc<br>
<<a href="mailto:kyoshida@novell.com">kyoshida@novell.com</a>><br>
<br>
</font></blockquote></div><br>