<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#ffffff"> Le 08/01/2011 08:39, Julien Nabet a écrit : <blockquote cite="mid:4D2814CD.4060105@yahoo.fr" type="cite"> <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> <pre>On Fri, 2011-01-07 at 11:07 +0000, Caolán McNamara wrote: > On Thu, 2011-01-06 at 20:36 +0100, Guillaume Poussel wrote: > > Hi everybody, > > > > > > A new patch which correct cppcheck warnings in base/. > > Looks good, pushed. Thanks for this. Oops, I see now that cppcheck isn't run with sufficient -I flags to find includes, so it wasn't able to see that pDesc is actually used by some MACRO stuff which was hidden from it, so these were cppcheck false positives, as are probably the "missing ctor" warnings. I fixed up the pDesc ones again in a way to hide them from cppcheck again. We probably should figure out how to sufficient -I flags to cppcheck to get it to find the includes. This is probably a bit tricky unless we add a make cppcheck or something to libreoffice itself or something. C. </pre> </blockquote> Hello, About cppcheck, perhaps it should be useful to use the latest version of cppcheck on the git repository. I attached the git log of what has been done since 14th of December (date of the release of 1.46.1). We can see that a lot of false positives have been corrected. I don't understand too the part about hiding something from cppcheck, wouldn't it be better to declare a new bug to cppcheck tracker ? But perhaps I misunderstood something Julien. </body> </html>