<br><br><div class="gmail_quote">2011/1/31 Michael Meeks <span dir="ltr"><<a href="mailto:michael.meeks@novell.com">michael.meeks@novell.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
On Sun, 2011-01-30 at 14:35 +0100, Kenneth Venken wrote:<br>
> So, should i make the changes to the code or have you already done<br>
> them?<br>
<br>
</div> Judging by the git log (they're not pushed), I'd say that Norbert<br>
wanted you to re-submit a patch with his suggestions :-)<br>
<br></blockquote><div>I think i've implemented all the suggestions. There's one hard coded limit (i < 0x1FFF) i don't get. Why isn't it 0x2000 since existMark has a size of 0x10000. I changed it to i < 0x2000. This will not have an influence on xdictionary since the 0x1FFF limit is hardcoded there too. I'll look into xdictionary next to see if i can fix the fixme in gendict. Maybe then this will make sence to me too.</div>
<div><br></div><div>I've also added support to print to standard output, but i don't know how to fix the build so it will pipe the output to the file. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Looks like some nice cleanups though,<br>
<br>
Thanks !<br>
<br>
Michael.<br>
<font color="#888888"><br>
--<br>
<a href="mailto:michael.meeks@novell.com">michael.meeks@novell.com</a> <><, Pseudo Engineer, itinerant idiot<br>
<br>
<br>
</font></blockquote></div><br>