<div>I don't think it's critial... None of the commits that removes brackets and improves SmNodeToTextVisitor have been applied to libreoffice-3-3... The SmNodeToTextVisitor there uses a lot of brackets, so there's hopefully no major issues with it...</div>
<div><br></div><div>In fact I've kept all the changes to the visual formula editor in the master branch... Some of them can, as previous changes to SmNodeToVisitor might have done, cause issues...</div><br clear="all">
--<br>Regards Jonas Finnemann Jensen.<br>
<br><br><div class="gmail_quote">On Mon, Jan 31, 2011 at 11:58, Michael Meeks <span dir="ltr"><<a href="mailto:michael.meeks@novell.com">michael.meeks@novell.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
On Sat, 2011-01-29 at 13:01 +0000, Luke Dixon wrote:<br>
> Some of the tests are the same kind as the one from last time. It can be<br>
> a bit difficult to get the right node tree for the test from the parser,<br>
> which also seems to put in more expression nodes than doing it with the<br>
> cursor, which confused me for a bit.<br>
<br>
</div> Quick query - did we want the core part of this on the libreoffice-3-3<br>
branch as well ?<br>
<br>
Thanks !<br>
<br>
Michael.<br>
<font color="#888888"><br>
--<br>
<a href="mailto:michael.meeks@novell.com">michael.meeks@novell.com</a> <><, Pseudo Engineer, itinerant idiot<br>
<br>
<br>
</font></blockquote></div><br>