<br><br><div class="gmail_quote">On Thu, Feb 17, 2011 at 6:06 PM, Jan Holesovsky <span dir="ltr"><<a href="mailto:kendy@suse.cz">kendy@suse.cz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Rafael,<br>
<br>
Rafael Dominguez píše v Ne 13. 02. 2011 v 23:40 +0000:<br>
<div class="im"><br>
> Well the patch is related to sw, tab entries in Insert->Indexes and<br>
> Tables -> Indexes and Tables.<br>
<br>
</div>Wow - if I am not mistaken, this is your first LibreOffice patch, and<br>
already quite a lot of work, thank you for that! :-) I updated few<br>
pieces in your patch, and pushed that to master:<br>
<br>
<a href="http://cgit.freedesktop.org/libreoffice/writer/commit/?id=da916c2962cdbaec95477f83f2729951bc0f5e5c" target="_blank">http://cgit.freedesktop.org/libreoffice/writer/commit/?id=da916c2962cdbaec95477f83f2729951bc0f5e5c</a><br>
<br>
If you can test with the updated version, that would be great.<br>
<br>
Can you please confirm that your contribution is LGPLv3+/MPL?<br>
<br>
The main thing that I changed was that in some cases you used<br>
vector<...>::iterator it = another_iterator + 1; This is not correct,<br>
operator+() is not defined on std::vector, so the result might be not<br>
what you'd expect; similarly with -1. I have changed those to ++it, or<br>
--it (on a temporary copy, or so).<br>
<br>
Other than that - very nice cleanup, looking forward to more! :-)<br>
<br>
All the best,<br>
Kendy<br>
<br>
</blockquote></div><br>Well since someone suggested to change it to boost::ptr_vector, i made a new patch i didnt expect to get pushed this fast, also fixed a small bug i had. All the patch is LGPLv3+/MPL ^^<br>