<br><br><div class="gmail_quote">On Mon, Feb 21, 2011 at 12:10 AM, Joseph Powers <span dir="ltr"><<a href="mailto:jpowers27@cox.net">jpowers27@cox.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div style="word-wrap: break-word;">Here's a quick update on the project:<div><br></div><div>1. The only items left are:</div><div><div><br></div><div>binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeConnections, DdeConnection* )</div>
<div>binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeTransactions, DdeTransaction* )</div><div>binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeFormats, long )</div><div>binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( StringList, String * )</div>
<div>binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeServices, DdeService* )</div><div>binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeTopics, DdeTopic* )</div><div>binfilter/inc/bf_svtools/svdde.hxx:DECLARE_LIST( DdeItems, DdeItem* )</div>
</div><div><br></div><div><div>idl/inc/lex.hxx:DECLARE_LIST( SvTokenList, SvToken * )</div><div>idl/inc/object.hxx:DECLARE_LIST( SvSlotElementList, SvSlotElement* )</div><div>idl/inc/types.hxx:DECLARE_LIST(SvMetaTypeList,SvMetaType *)</div>
</div><div><br></div><div><div>svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeConnections, DdeConnection* )</div><div>svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeServices, DdeService* )</div><div>svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeTopics, DdeTopic* )</div>
<div>svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeItems, DdeItem* )</div><div>svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeTransactions, DdeTransaction* )</div><div>svl/inc/svl/svdde.hxx:DECLARE_LIST( DdeFormats, long )</div><div>svl/inc/svl/svdde.hxx:DECLARE_LIST( StringList, String * )</div>
<div>svl/source/svdde/ddeimp.hxx:DECLARE_LIST( ConvList, Conversation* );</div><div><br></div><div>tools/inc/tools/list.hxx:// - DECLARE_LIST -</div><div>tools/inc/tools/list.hxx:#define DECLARE_LIST( ClassName, Type ) \</div>
<div>tools/inc/tools/ref.hxx:DECLARE_LIST(CN##List,EN)\</div></div><div><br></div><div>2. We also have a few locations where the "List" class is used directly with out the DECLARE_LIST() macro.</div><div><br></div>
<div>My work order is:</div><div><br></div><div>1. Reduce the number of #include "tools/list.hxx" down to a minimum (it should only be used in areas that use the List class).</div><div>2. Convert the binfilter & svl items above to a ::std::vector<> or similar template. These files are only used on MS-Windows which I don't build on, so I'm going to just create the patches and then send them to Fridrich who volunteered to make sure the build ok.</div>
<div>3. Fix the tools/inc/tools/ref.hxx usage of DECLARE_LIST. The issue here is that it's a macro that's used in several locations.</div><div><br></div><div>Rafael is working on the following areas:</div><div><br>
</div><div>1. Convert the idl items above.</div><div>2. Start converting the code that uses the List class.</div><div><br></div><div>Joe P.</div><div><br></div><div>PS: Rafeal, I pushed your patch to convert the std::vector to boost::ptr_vector in writer. Sorry I don't know how to preserve your submitter information (my git foo is bad). I had one section that did not apply cleanly so I had to patch that section manually. Can you double check my work and make sure it's what you wanted? I did a "make check" and also tested the menu item directly and it seems to work.</div>
<div><span style="font-family: sans-serif; color: rgb(51, 51, 51); font-size: 13px;"><table summary="commit info" style="padding: 0em; margin: 1.5em 0em 0em; border-collapse: collapse;"><tbody><tr><th style="text-align: left; font-weight: normal; padding: 0.1em 1em 0.1em 0.1em; vertical-align: top;">
author</th><td style="font-weight: normal; padding: 0.1em 1em 0.1em 0.1em;">Joseph Powers <<a href="mailto:jpowers27@cox.net" target="_blank">jpowers27@cox.net</a>></td><td style="text-align: right; font-weight: normal; padding: 0.1em 1em 0.1em 0.1em;">
2011-02-21 04:13:57 (GMT)</td></tr><tr><th style="text-align: left; font-weight: normal; padding: 0.1em 1em 0.1em 0.1em; vertical-align: top;">committer</th><td style="font-weight: normal; padding: 0.1em 1em 0.1em 0.1em;">
Joseph Powers <<a href="mailto:jpowers27@cox.net" target="_blank">jpowers27@cox.net</a>></td><td style="text-align: right; font-weight: normal; padding: 0.1em 1em 0.1em 0.1em;">2011-02-21 04:13:57 (GMT)</td></tr><tr>
<th style="text-align: left; font-weight: normal; padding: 0.1em 1em 0.1em 0.1em; vertical-align: top;">commit</th><td colspan="2" style="font-family: monospace; font-size: 12px; font-weight: normal; padding: 0.1em 1em 0.1em 0.1em;">
<a href="http://cgit.freedesktop.org/libreoffice/writer/commit/?id=5d8a59f64d9d3931e2c9c1ba98f57cd10e0b01c1" style="color: blue; text-decoration: none;" target="_blank">5d8a59f64d9d3931e2c9c1ba98f57cd10e0b01c1</a> (<a href="http://cgit.freedesktop.org/libreoffice/writer/patch/?id=5d8a59f64d9d3931e2c9c1ba98f57cd10e0b01c1" style="color: blue; text-decoration: none;" target="_blank">patch</a>)</td>
</tr></tbody></table></span><div><br></div></div></div></blockquote></div><br>Yes sorry for that, thanks!!! looks perfect<br>