<br><br><div class="gmail_quote">On Tue, Feb 22, 2011 at 1:35 PM, Jan Holesovsky <span dir="ltr"><<a href="mailto:kendy@suse.cz">kendy@suse.cz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Joseph,<br>
<div class="im"><br>
On 2011-02-20 at 20:40 -0800, Joseph Powers wrote:<br>
> Here's a quick update on the project:<br>
><br>
> 1. The only items left are:<br>
<br>
</div>Very nice! :-)<br>
<div class="im"><br>
> 2. We also have a few locations where the "List" class is used<br>
> directly with out the DECLARE_LIST() macro.<br>
><br>
><br>
> My work order is:<br>
><br>
><br>
> 1. Reduce the number of #include "tools/list.hxx" down to a minimum<br>
> (it should only be used in areas that use the List class).<br>
> 2. Convert the binfilter & svl items above to a ::std::vector<> or<br>
> similar template. These files are only used on MS-Windows which I<br>
> don't build on, so I'm going to just create the patches and then send<br>
> them to Fridrich who volunteered to make sure the build ok.<br>
<br>
</div>My take would be - don't care about binfilter that much ;-) If the code<br>
other than binfilter compiles without eg. DECLARE_LIST (or the List<br>
type), I'd just move the macro (or the List type) from tools/ to a<br>
header that is internal for binfilter, and let it be (for now); it might<br>
very much turn out that it will be deleted by the removal of write<br>
support in binfilter.<br>
<br>
[But of course, if you want to get rid of that for good, go for that.]<br>
<div class="im"><br>
> 3. Fix the tools/inc/tools/ref.hxx usage of DECLARE_LIST. The issue<br>
> here is that it's a macro that's used in several locations.<br>
><br>
> Rafael is working on the following areas:<br>
><br>
> 1. Convert the idl items above.<br>
> 2. Start converting the code that uses the List class.<br>
<br>
</div>Cool!<br>
<br>
[BTW, another list-like thing that I've just spotted:<br>
<a href="http://opengrok.libreoffice.org/xref/libs-gui/vcl/inc/list.h" target="_blank">http://opengrok.libreoffice.org/xref/libs-gui/vcl/inc/list.h</a> ]<br>
<br>
Thank you a lot, this rocks, :-)<br>
Kendy<br>
<br>
<br>
</blockquote></div>lol how many list implementations they got in the code?? xD talking about duplicating their efforts =P<br><br>