<span lang="DE"> <div>// #FIXME this *MUST* be wrong documents::close surely closes ALL documents</div> <div>// in the collection, use of getCurrentDocument here is totally wrong</div> <div>-/*</div> <div>- uno::Reference< lang::XMultiComponentFactory > xSMgr(</div> <div>- mxContext->getServiceManager(), uno::UNO_QUERY_THROW );</div> <div>- uno::Reference< frame::XModel > xModel( getCurrentDocument(), uno::UNO_QUERY_THROW );</div> <div>- rtl::OUString url = rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( ".uno:CloseDoc"));</div> <div>- dispatchRequests(xModel,url);</div> <div>-*/</div></span><br><br> <div class="gmail_quote">2011/3/17 Jan Holesovsky <span dir="ltr"><<a href="mailto:kendy@suse.cz">kendy@suse.cz</a>></span><br> <blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">Hi Xisco,<br> <div> <div></div> <div class="h5"><br>On 2011-03-12 at 02:25 +0100, Xisco Faulí wrote:<br><br>> I've seen quite often something like this:<br>><br>> -/*<br>> - #i2345#<br>> - if ( nSlotId >= SID_SFX_START && !<br> > SfxMenuManager::IsPopupFunction(nSlotId) )<br>> - {<br>> - // Echte Popups sollen keine SlotIds haben; leider sind<br>> - // da noch Altlasten mit herumzuschleppen ...<br>> - String aTitle = pSVMenu->GetItemText( nSlotId );<br> > - pSVMenu->SetPopupMenu( nSlotId, NULL );<br>> - USHORT nPos = pSVMenu->GetItemPos( nSlotId );<br>> - pSVMenu->RemoveItem( nPos );<br>> - nSlotId = 1;- while ( pSVMenu->GetItemPos(nSlotId) !=<br> > MENU_ITEM_NOTFOUND ) - nSlotId++; - pSVMenu->InsertItem( nSlotId,<br>> aTitle, 0, nPos ); - pSVMenu->SetPopupMenu( nSlotId, pPopup ); - } -*/<br>> What should I do with it ? leave it like that ? delete it completery ?<br> > or delete the code and leave the bogus ?<br><br></div></div>Delete entirely :-)<br> <div class="im"><br>> Btw, what about the peaces which say, FIXME ?<br><br></div>Do you have an example, please?<br><br>Regards,<br>Kendy<br><br><br></blockquote></div><br>