yeah, it's right, the code looks as follow:<div><br></div><div><div> OSL_ENSURE( aInfo.mpOldBasicPassword, "ImplRepository::impl_createManagerForModel: wrong BasicLibraries implementation!" );</div><div>
pBasicManager->SetLibraryContainerInfo( aInfo );</div><div> //pBasicCont->setBasicManager( pBasicManager );</div><div> // that's not needed anymore today. The containers will retrieve their associated</div>
<div> // BasicManager from the BasicManagerRepository, when needed.</div><div><br></div><div> // initialize the containers</div><div> impl_initDocLibraryContainers_nothrow( xBasicLibs, xDialogLibs );</div>
<div><br></div><div>So it can be deleted because it refers to //pBasicCont->setBasicManager( pBasicManager );</div><meta http-equiv="content-type" content="text/html; charset=utf-8"><br><div class="gmail_quote">2011/3/20 Christina Roßmanith <span dir="ltr"><<a href="mailto:ChrRossmanith@web.de">ChrRossmanith@web.de</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi,<br>
<br>
I'm reviewing and applying patches removing commented code. What about the following lines from source/basmgr/basicmanagerrepository.cxx?<br>
<br>
//pBasicCont->setBasicManager( pBasicManager );<br>
// that's not needed anymore today. The containers will retrieve their associated<br>
// BasicManager from the BasicManagerRepository, when needed.<br>
<br>
<br>
I have the feeling, that the text-comment belongs to the commented line of code above. Is that true? In that case it can be removed as well (I'll do that if I get an ok for that).<br>
<br>
Christina<br>
_______________________________________________<br>
LibreOffice mailing list<br>
<a href="mailto:LibreOffice@lists.freedesktop.org" target="_blank">LibreOffice@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a><br>
</blockquote></div><br></div>