Ok Cedric, no problem. I will fix these problems.<div><br></div><div>Thank you for return.</div><div><br></div><div>Regards,</div><div>Júlio.<br><br><div class="gmail_quote">2011/4/15 Cedric Bosdonnat <span dir="ltr"><<a href="mailto:cedric.bosdonnat.ooo@free.fr">cedric.bosdonnat.ooo@free.fr</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi Julio,<br>
<br>
Many thanks for your patches nice patches. I think we'll manage to<br>
eradicate loads of useless comments this way ;)<br>
<br>
I pushed both patches in libs-gui and libs-core after some manual edits,<br>
but it takes too much time to manually adjust the patch for sw. Could<br>
you please adjust your regexps to fix the following problems:<br>
* comments indentation is reduced to 4 spaces in all cases: you should<br>
keep the number of existing leading spaces to avoid breaking the<br>
indentation<br>
* #b[0-9]\+# comments should be purely removed: we don't need them as<br>
they refer to some Oracle internal bug database. Please pay attention<br>
here ase you may have #b...# and #i....# references on the same line<br>
* you often have some comment after the bug number, please keep them.<br>
Some could be removed, but not all.<br>
* While at it, could you remove the lines with comments like '// <--'<br>
as those are the "closing" comments for the other silly SCM-like<br>
comments?<br>
<br>
Don't forget to check your patch after running your regexps as you may<br>
have other unexpected cases.<br>
<br>
Regards,<br>
<div><div></div><div class="h5"><br>
On Thu, 2011-04-14 at 19:26 -0300, Júlio Hoffimann wrote:<br>
> I forget to mention...<br>
><br>
><br>
> This patch is under the LGPLv3+ / MPL license.<br>
><br>
> 2011/4/14 Júlio Hoffimann <<a href="mailto:julio.hoffimann@gmail.com">julio.hoffimann@gmail.com</a>><br>
> ... and the last and big one. ;-)<br>
><br>
><br>
> <a href="https://bugs.freedesktop.org/show_bug.cgi?id=36234" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=36234</a><br>
><br>
><br>
> Regards,<br>
> Júlio.<br>
><br>
><br>
><br>
><br>
</div></div>> _______________________________________________<br>
> LibreOffice mailing list<br>
> <a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a><br>
<font color="#888888"><br>
--<br>
Cédric Bosdonnat<br>
LibreOffice hacker<br>
<a href="http://documentfoundation.org" target="_blank">http://documentfoundation.org</a><br>
OOo Eclipse Integration developer<br>
<a href="http://cedric.bosdonnat.free.fr" target="_blank">http://cedric.bosdonnat.free.fr</a><br>
<br>
</font></blockquote></div><br></div>