Hi,<br><br>Any idea about my experimental fix? i.e. remove the auto-style that switch to the very same locale.<br><br><div class="gmail_quote">On Tue, May 24, 2011 at 9:22 PM, Samphan Raruenrom <span dir="ltr"><<a href="mailto:samphan@osdev.co.th">samphan@osdev.co.th</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div bgcolor="#ffffff" text="#000000">
Hi,<br>
<br>
We've been trying to fix this bug
<a href="https://bugs.freedesktop.org/show_bug.cgi?id=33092" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=33092</a><br>
<br>
However, we don't know whether the approach that we've tried is the
right thing, so can you please review the following idea.<br>
<br>
Step to reproduced the bug:<br>
<br>
1.Use Thai locale, open a blank Writer document<br>
2.Switch keyboard to Thai.<br>
3.Type text “มิถุ” by press “,b5”.<br>
4.The function autocomplete will display the full word "มิถุนายน"
(June in Thai)<br>
5. Press enter to accept the suggestion, and another enter for
readability<br>
6. Repeat the step 3-5 once<br>
<br>
Expect result:<br>
There should be two lines of “มิถุนายน”.<br>
<br>
Real result: <br>
There are two lines of “มิถุนายน” but the first one has a
doubled/overlapped cluster. See below.<br>
<img src="cid:part1.05060200.05020007@osdev.co.th" alt=""><br>
<br>
It is strange that the second (and later) autocompletion of the same
word doesn't trigger the same bug.<br>
<br>
Look at the content.xml<br>
<blockquote>
<pre><tt><style:style style:name="T1" style:family="text">
<style:text-properties style:language-complex="th"
style:country-complex="TH"/>
</style:style>
....snip.....
<text:p text:style-name="P1">มิถ<text:span text:style-name="T1">ุนายน</text:span></text:p>
<text:p text:style-name="P1"><text:span text:style-name="T1">มิถุนายน</text:span></text:p></tt>
</pre>
</blockquote>
There is an auto-style T1 which switch the locale to th. In the 2nd
paragraph, the auto-style is placed around the autocompleted word.
However, in the first line, the auto-style is placed just before the
suggestion. Moreover, for the word มิถุนายน, the auto-style happen
to be placed inside a cluster ถ+ ุ , which result in ugly display of
the cluster. Because the display function still cannot handle this
case well.<br>
<br>
We've tried removing the whole auto-style T1 from the ODT and
everything is fine again. Then we couldn't find a reason why LO need
to put the auto-style while autocomplete in the first place. Because
the user is typing in a locale, then autocompletion of the same
locale is fired. So the whole text must be in the same locale. Why
put and auto-style to switch to the same locale?<br>
<br>
So we've try an experimental patch
(<a href="https://bugs.freedesktop.org/attachment.cgi?id=45511" target="_blank">https://bugs.freedesktop.org/attachment.cgi?id=45511</a> ) that get rid
of the auto-style when autocomplete altogether. We've tried it with
no side-effect as of now. But I don't know whether actually the
auto-style is needed for a reason we don't understand.<br>
<br>
Any idea?<br>
<br>
Thanks,<br>
Samphan.<br><font color="#888888">
<div>-- <br>
_/|\_ <i>Samphan Raruenrom.</i> Osdev - Open Source Development
Co., Ltd.<br>
<i>สัมพันธ์ ระรื่นรมย์.</i> โอเอสเด็บ - บริษัท
โอเพนซอร์สดิเวลอปเมนต์ จำกัด<br>
tel: +66 2 269 9889 web: <a href="http://www.osdev.co.th/" target="_blank">osdev.co.th</a><br>
twitter: <a href="http://twitter.com/osdev" target="_blank">@osdev</a> facebook:
<a href="http://www.facebook.com/osdev" target="_blank">facebook.com/osdev</a></div>
</font></div>
</blockquote></div><br><br clear="all"><br>-- <br>_/|\_ Samphan Raruenrom. Open Source Development Co., Ltd.<br>Tel: +66 38 311816, Fax: +66 38 773128, <a href="http://www.osdev.co.th/">http://www.osdev.co.th/</a><br>