On Tue, May 31, 2011 at 5:56 PM, Cedric Bosdonnat <<a href="mailto:cedric.bosdonnat.ooo@free.fr">cedric.bosdonnat.ooo@free.fr</a>> wrote: <div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> Hello Samphan, <div class="im"> On Tue, 2011-05-31 at 12:32 +0700, Samphan Raruenrom wrote: > Any idea about my experimental fix? i.e. remove the auto-style that > switch to the very same locale. </div>It doesn't look bad to me but I could go into deeper investigation as I couldn't type that word using any of the thai layouts from scim. Could you give us some more hints to type this on scim? </blockquote><div> Here are the steps to reproduced the bug: 1. open a blank Writer document. Switch LibO to Thai locale. Tools > Options > Language Settings > Locale Setting = Thai 2.Switch keyboard to Thai. I know nothing about skim but I've just tried and found that you only need to add support for Thai (e.g. on Ubuntu). Then you switch the keyboard to Thai using Alt+Shift+L. 3.Type text “มิถุ” by press “,b56”. (I miss the last character in the previous message, sorry :'( ) When you've switched the keyboard to Thai, simply type , (comma) -- to get -> ม b -- to get -> ิ 5 -- to get -> ถ 6 -- to get -> ุ 4.The function autocomplete will display the full word "มิถุนายน" (June in Thai) 5. Press enter to accept the suggestion, and another enter for readability 6. Repeat the step 3-5 once Expect result: There should be two lines of “มิถุนายน”. Real result: There are two lines of “มิถุนายน” but the first one has a doubled/overlapped cluster. See below. <img src="cid:part1.05060200.05020007@osdev.co.th" alt=""> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Did you try to type some text in another language (and trigger autocorrection too) between those two iterations of the steps to see if your patch didn't alterate anything there? </blockquote><div> Not yet. But I'll try it, ASAP. I think this case is very specific, i.e. the 3rd and the 4th characters happen to be in the same cluster (the first 3 chars tricker the autocompletion). I think we can always artificially create such case in any language with non-spacing, composing characters. For Thai, it happen that we have such case in the default autocompletion list which is the month name (มิถุนายน = June). So people have to fight with it all the time. </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> My last question is how do it come that this language setting alters the first word but not the second one? </blockquote><div> I completely have no idea. </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div><div></div><div class="h5"> > On Tue, May 24, 2011 at 9:22 PM, Samphan Raruenrom > <<a href="mailto:samphan@osdev.co.th">samphan@osdev.co.th</a>> wrote: > Hi, > > We've been trying to fix this bug > <a href="https://bugs.freedesktop.org/show_bug.cgi?id=33092" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=33092</a> > > However, we don't know whether the approach that we've tried > is the right thing, so can you please review the following > idea. > > Step to reproduced the bug: > > 1.Use Thai locale, open a blank Writer document > 2.Switch keyboard to Thai. > 3.Type text “มิถุ” by press “,b5”. > 4.The function autocomplete will display the full word > "มิถุนายน" (June in Thai) > 5. Press enter to accept the suggestion, and another enter for > readability > 6. Repeat the step 3-5 once > > Expect result: > There should be two lines of “มิถุนายน”. > > Real result: > There are two lines of “มิถุนายน” but the first one has a > doubled/overlapped cluster. See below. > > > It is strange that the second (and later) autocompletion of > the same word doesn't trigger the same bug. > > Look at the content.xml > <style:style style:name="T1" style:family="text"> > <style:text-properties style:language-complex="th" > style:country-complex="TH"/> > </style:style> > ....snip..... > <text:p text:style-name="P1">มิถ<text:span text:style-name="T1">ุนายน</text:span></text:p> > <text:p text:style-name="P1"><text:span text:style-name="T1">มิถุนายน</text:span></text:p> > There is an auto-style T1 which switch the locale to th. In > the 2nd paragraph, the auto-style is placed around the > autocompleted word. However, in the first line, the auto-style > is placed just before the suggestion. Moreover, for the word > มิถุนายน, the auto-style happen to be placed inside a cluster > ถ+ ุ , which result in ugly display of the cluster. Because > the display function still cannot handle this case well. > > We've tried removing the whole auto-style T1 from the ODT and > everything is fine again. Then we couldn't find a reason why > LO need to put the auto-style while autocomplete in the first > place. Because the user is typing in a locale, then > autocompletion of the same locale is fired. So the whole text > must be in the same locale. Why put and auto-style to switch > to the same locale? > > So we've try an experimental patch > (<a href="https://bugs.freedesktop.org/attachment.cgi?id=45511" target="_blank">https://bugs.freedesktop.org/attachment.cgi?id=45511</a> ) that > get rid of the auto-style when autocomplete altogether. We've > tried it with no side-effect as of now. But I don't know > whether actually the auto-style is needed for a reason we > don't understand. > > Any idea? > > Thanks, > Samphan. > -- > _/|\_ Samphan Raruenrom. Osdev - Open Source Development Co., > Ltd. > สัมพันธ์ ระรื่นรมย์. โอเอสเด็บ - บริษัท > โอเพนซอร์สดิเวลอปเมนต์ จำกัด > tel: +66 2 269 9889 web: <a href="http://osdev.co.th" target="_blank">osdev.co.th</a> > twitter: @osdev facebook: <a href="http://facebook.com/osdev" target="_blank">facebook.com/osdev</a> > > > > -- > _/|\_ Samphan Raruenrom. Open Source Development Co., Ltd. > Tel: +66 38 311816, Fax: +66 38 773128, <a href="http://www.osdev.co.th/" target="_blank">http://www.osdev.co.th/</a> </div></div>> _______________________________________________ > LibreOffice mailing list > <a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a> > <a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a> -- Cédric Bosdonnat LibreOffice hacker <a href="http://documentfoundation.org" target="_blank">http://documentfoundation.org</a> OOo Eclipse Integration developer <a href="http://cedric.bosdonnat.free.fr" target="_blank">http://cedric.bosdonnat.free.fr</a> </blockquote></div> -- _/|\_ Samphan Raruenrom. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, <a href="http://www.osdev.co.th/">http://www.osdev.co.th/</a>