Hi everybody,<br><br>I have made some stats to check the number of duplicate icons in the clone/artwork directory:<br><br>$ find . -name "*.png" -exec md5sum {} \; > /tmp/icon_list.txt<br>
<br>$ wc -l /tmp/icon_list.txt<br>23916 /tmp/icon_list.txt<br><br>$ cat /tmp/icon_list.txt | cut -d " " -f 1 | sort | uniq -c | wc -l<br>
15063<br><br>Only 15063 unique icons out of a total of 23916...<br><br><br>$ cat /tmp/icon_list.txt | cut -d " " -f 1 | sort | uniq -c | sort -nr<br> 139 807dae78a1ec98d3ea5b3e32c98ffe90<br><div> 96 80d815d13cda9b63ebd372fec588cfd5<br>
51 b39f5c7219187dad35226d3643ac2d3f<br> 51 4bd00715b1e5beb713c04f887e9835ef<br>...<br><br>Let's start with the most duplicated one <br>$ grep 807dae78a1ec98d3ea5b3e32c98ffe90 /tmp/icon_list.txt | sort<br>807dae78a1ec98d3ea5b3e32c98ffe90 ./default_images/fpicker/res/list.png<br>
807dae78a1ec98d3ea5b3e32c98ffe90 ./default_images/res/missing_icon.png<br>807dae78a1ec98d3ea5b3e32c98ffe90 ./default_images/sfx2/res/command.png<br>807dae78a1ec98d3ea5b3e32c98ffe90 ./default_images/sfx2/res/dictate.png<br>
...<br>807dae78a1ec98d3ea5b3e32c98ffe90 ./ooo_custom_images/oxygen/res/sx03124.png<br>807dae78a1ec98d3ea5b3e32c98ffe90 ./ooo_custom_images/oxygen/res/sx03134.png<br>
...<br><br>These are icons that can be replaced by the default fallback icon. The attached patch #1 delete all these icons.<br><br><br>The second most duplicated :<br>$ grep 80d815d13cda9b63ebd372fec588cfd5 /tmp/icon_list.txt | sort <br>
80d815d13cda9b63ebd372fec588cfd5 ./default_images/sfx2/res/ln0100.png<br>
80d815d13cda9b63ebd372fec588cfd5 ./default_images/sfx2/res/ln0102.png<br>80d815d13cda9b63ebd372fec588cfd5 ./default_images/sfx2/res/ln0104.png<br>80d815d13cda9b63ebd372fec588cfd5 ./default_images/sfx2/res/ln0106.png<br>
<br>All these ones can also be replaced by the fallback icon. patch #2 deletes all these icons.<br><br><br>Next one ...<br>$ grep b39f5c7219187dad35226d3643ac2d3f /tmp/icon_list.txt | sort<br>
b39f5c7219187dad35226d3643ac2d3f ./ooo_custom_images/crystal/cmd/ar/lc_underlinedouble.png<br>...<br>b39f5c7219187dad35226d3643ac2d3f ./ooo_custom_images/crystal/cmd/ko/lc_underlinedouble.png<br>b39f5c7219187dad35226d3643ac2d3f ./ooo_custom_images/crystal/cmd/lc_underlinedouble.png<br>
b39f5c7219187dad35226d3643ac2d3f ./ooo_custom_images/crystal/cmd/nl/lc_underlinedouble.png<br>...<br>b39f5c7219187dad35226d3643ac2d3f ./ooo_custom_images/crystal/cmd/tr/lc_underlinedouble.png<br>b39f5c7219187dad35226d3643ac2d3f ./ooo_custom_images/oxygen/cmd/cs/lc_underlinedouble.png<br>
...<br>b39f5c7219187dad35226d3643ac2d3f ./ooo_custom_images/oxygen/cmd/km/lc_underlinedouble.png<br><br>The locale directories redefine the main icon defined in ./ooo_custom_images/crystal/cmd and ./ooo_custom_images/oxygen/cmd<br>
The attached patch #3 takes care of these unnecessary icons.<br><br>If this patch is OK, I will continue with all the other duplicated icons. <br>I think it will allow a massive cleanup in the different locale directories.<br>
<br><br>Can you please review these patches?<br><br>Regards,<br>Joachim.<br><br><br></div>