<br><br><div class="gmail_quote">On Tue, Jun 7, 2011 at 8:19 PM, Rafael Dominguez <span dir="ltr"><<a href="mailto:venccsralph@gmail.com">venccsralph@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Also haven't pushed<br>
0002-Replace-List-with-std-vector-XclExpUserBView.calc.patch because I<br>
am not sure about<br>
<br>
--- cut ---<br>
 XclExpUserBViewList::XclExpUserBViewList( const ScChangeTrack& rChangeTrack )<br>
+ Â Â : aViews(rChangeTrack.GetUserCollection().GetCount())<br>
[...]<br>
- Â Â Â Â Â Â List::Insert( new XclExpUserBView( pStrData->GetString(), aGUID ), LIST_APPEND );<br>
+ Â Â Â Â Â Â aViews.push_back( new XclExpUserBView( pStrData->GetString(), aGUID ) );<br>
--- cut ---<br>
<br>
Why do you initialize the vector with NULL pointers?<br>
<br>
IMHO, all the pointers will stay NULL because you later use .push_back().<br>
<br>
For example, rChangeTrack has the collection: A B C D and GetCount() returns 4.<br>
If you initialize the vector, you will end with the vector: 0 0 0 0 A B C D<br>
<br>
Or did I miss something?<br>
<font color="#888888"><br></font></blockquote></div><div><br>Nope, heres a patch fixing those issues<br></div></div><br>
</blockquote></div><br>Forgot to remove the initializing the vector changed it for reserve. Tripled checked so it should be fine now<br>