On Tue, Jun 14, 2011 at 12:57 PM, Petr Mladek <span dir="ltr"><<a href="mailto:pmladek@suse.cz" target="_blank">pmladek@suse.cz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="im"> John LeMoyne Castle píše v Po 13. 06. 2011 v 15:27 -0700:<br> > Hi Petr,<br></div> ... </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"> > Anything else that should go into -wikify?<br><br></div> ... </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The [wiki] output might be quite<br> similar after all.<br></blockquote><div><br></div><div>I will add a new format option </div><div> <br>... <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"> Note that I use the command also the generate commit statistics for<br> releases. It needs to filter the log also by tags, ... <br></div> Please, keep this possibility.<br></blockquote><div> </div><div>Got it. </div><div class="im"> <div> </div> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I suggest to separate the date and output format definitions.</blockquote><div> </div></div><div>Will do</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Anyway, I do not say that the current options are the best way to<br> define all the things. Feel free to come up with a better proposal.<br></blockquote><div> </div></div><div>A proposal that seems much better than my first thought: </div><div>I will tinker with lo-commit-stat but will try to avoid major refactor: <br> </div><div><div>After poking at lo-commit-stat a little bit last night, I think the best plan is to write a lo-commit-wikify wrapper that converts year&week to git-args --after/since and --before/until and then calls lo-commit-stat . The wrapper would also help us catch up with an -all [weeks] arg or some such and drive lo-commit-stat through the branch tags separately. This step through the branch/tags idea was so the log output doesn't have to be rewritten or parsed. But after re-reading the note above about --log-suffix I see it may be easier that I thought...<br> </div><div><br></div><div>The main additions in lo-commit-stat would be output changes: wiki formatted lines (====headers for sub-repos), wrapping the bug numbers to wiki external links and (maybe) log append </div><div> lo-commit-wikify would create the other parts of the wiki page before and after the commit list from lo-commit-stat.</div> <div><br></div><div>I will attempt some other improvements as well re: bug numbers and ordering commits by time (so msgs like: fixed prev commit [/somebody] are clearer)</div><div>I will also look at rolling-up some stats like: # commits and #changes </div> <div><br></div><div>I will not do the extraction of common to all because there is also the case of common to a few and -</div><div>you have reminded me that a) it isn't trivial and b) it will all be moot if sub-repos are merged.</div> <div><br></div><div>I do see that checking all branches for the presence of a patch or patch set is valuable, but code config study/debug is different than this statistic generator</div><div><br></div><div>CPAN provides access to handy week functions in DateTime so converting week/year to start/end dates looks straightforward</div> </div><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Also feel free to refactor the whole script. It is possible that you<br> would need another structure of the subroutines, more parameters, ... </blockquote><div><br></div></div><div>I will try to avoid this if possible - at least on the first pass. </div> <div>Perhaps in future after gaining experience</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I am looking forward to see changes from you.<br> <br> Feel free to ask if you are in doubts with anything.</blockquote><div><br></div></div><div><div>OK here goes... <br></div><div><br></div><div>I know I need to pull to get the latest commits. After </div><div>$> ga pull -r </div> <div>in a repo on <some branch>, do I have the commit info for *all* branches/tags? </div> </div><div>Thanks.</div><div>I will put your name on it.</div><div><br></div><div>--jlc LeMoyne </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Best Regards,<br> <font color="#888888">Petr<br> <br> </font></blockquote><br> <br>