Hello Kohei,<br><br>thanks that you had a quick look at this patch.<br><br><div class="gmail_quote">2011/6/30 Kohei Yoshida <span dir="ltr"><<a href="mailto:kohei.yoshida@gmail.com">kohei.yoshida@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">The last time I checked, in the old code bForFile could still be true.<br>
I also assumed that it was always false and removed the if statement,<br>
but that caused a crasher bug (because it could be true sometimes).<br>
Since then I've refactored that code but the new code still contained<br>
the if block to reflect the old behavior.<br>
<br>
Have you guys checked a scenario where the source data range begins<br>
with a column other than Column A? That's when the nSrcColOffset can<br>
become non-zero, and setting it to always zero *might* break it<br>
especially for that scenario. So, before committing that fix, I'd<br>
like that scanrio to be tested just to feel safe and secure.<br></blockquote><div><br>I've checked this now but can't create any crashes.<font color="#888888"> <span style="color: rgb(0, 0, 0);">But as much as I see from some other bug reports, there are more problems with pivot tables at the moment and not all seem to be reproducible in all environments.</span><br style="color: rgb(0, 0, 0);">
<span style="color: rgb(0, 0, 0);">I think it might be best that we don't change anything further in the pivot table code and you have a look at it when you're back.<br><br>Have a nice holiday.<br><br>Regards,<br>
Markus<br></span></font></div></div><br>