Hi Caol<meta http-equiv="content-type" content="text/html; charset=utf-8">án, all,<div><br></div><div>Thanks for your review. The patch is indeed under LGPLv3+/MPL license.</div><div><br></div><div>I will have a look to your additional patch as soon as possible, thanks a lot.</div>
<div><br></div><div>I indeed saw some troubles with the current "search and replace" mechanism of writer. For example the "Find in selection" is not working properly : if you select a text after having opened the "search and replace" dialog, this text will not be taken in account by the "Find in selection", and some others bugs. I intend to work on it, patch after patch after ...</div>
<div><br></div><div>Cheers,</div><div><br></div><div><br></div><div>Benoit</div><div><br><div class="gmail_quote">2011/7/4 Caolán McNamara <span dir="ltr"><<a href="mailto:caolanm@redhat.com">caolanm@redhat.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">On Sun, 2011-07-03 at 23:07 +0200, Benoit Dolives wrote:<br>
<br>
Yup, patch fixes fixes the problem. Thanks for this. Pushed now to<br>
master.<br>
<br>
Can you confirm that this is under our preferred LGPLv3+/MPL license<br>
combo ?<br>
<div class="im"><br>
> Concerning your open question, the proposed patch checks if the<br>
> searched string belongs to the selection by using the same mechanism<br>
> as the common search command. Therefore it should have the same<br>
> behaviour as the search command in both cases (common or advanced<br>
> search/replace).<br>
<br>
</div>Hmm, if I stick e.g. Apple banana in there, select nothing, search and<br>
replace with regular expression of b.*a to match banana but where the<br>
search string has a different length to the text it will match, with<br>
"comments" enabled, then that one doesn't replace.<br>
<br>
AFAICS that "length is the same" branch is just an optimization. When<br>
removed everything works as I would expect, so I pushed that as a follow<br>
up fix.<br>
<br>
Would be good if you could double-check my changes there, and if the<br>
equal length code is based on some other code elsewhere, there might be<br>
an additional fix needed for the legacy stuff too.<br>
<br>
There's probably a few more gotchas with search and replace in writer,<br>
(e.g. how come I can't use "replace all" when comments are selected) if<br>
you dig around bugzilla for them :-)<br>
<font color="#888888"><br>
C.<br>
<br>
<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Benoit Dolives<br>
</div>