<blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">
<span class="Apple-style-span" style="border-collapse: collapse; color: rgb(51, 51, 51); font-family: arial, sans-serif; font-size: 13px; ">Please let me know if it looks problematic</span></blockquote><div>Looks great :)</div>
<br><div>--<br>Regards Jonas Finnemann Jensen.<br>
<br><br><div class="gmail_quote">On Fri, Jul 15, 2011 at 18:25, Miklos Vajna <span dir="ltr"><<a href="mailto:vmiklos@frugalware.org">vmiklos@frugalware.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Jonas,<br>
<div class="im"><br>
On Fri, Jul 15, 2011 at 01:45:42PM +0200, Jonas Finnemann Jensen <<a href="mailto:jopsen@gmail.com">jopsen@gmail.com</a>> wrote:<br>
> Your patch looks good, have you pushed it?<br>
<br>
</div>I just did so.<br>
<div class="im"><br>
> I don't think it hides a deeper problem (except lack of comments :) ), as<br>
> far as I remember there're other places where pViewShell->GetEditWindow() is<br>
> NULL tested. Also the method explicity returns NULL when the edit window<br>
> doesn't exists (I'm guessing either not created yet, or disabled).<br>
> - So I think it's okay.<br>
<br>
</div>Here is a second commit that fixes a similar crash when experimental<br>
features are enabled (in particular your inline editor):<br>
<br>
<a href="http://cgit.freedesktop.org/libreoffice/writer/commit/?id=94959497c0a9fe956f0b12a35ae98148db25bd62" target="_blank">http://cgit.freedesktop.org/libreoffice/writer/commit/?id=94959497c0a9fe956f0b12a35ae98148db25bd62</a><br>
<br>
Please let me know if it looks problematic. (The story is simpler in<br>
this case: try to load<br>
<a href="http://people.freedesktop.org/~vmiklos/math.word2007.docx" target="_blank">http://people.freedesktop.org/~vmiklos/math.word2007.docx</a>, double click<br>
on the formula and Math will crash instantly.)<br>
<div class="im"><br>
> By the way, nice to see that you're working GSoC again this year.<br>
<br>
</div>:)<br>
</blockquote></div><br></div>