Hi, Regarding the fact that I may have trimmed too many outline levels as well as leaving some extraneous comments, I will resubmit the patch. Sorry for the trouble, Jeffrey <div class="gmail_quote"> On Wed, Aug 3, 2011 at 4:04 PM, jeffrey chang <<a href="mailto:jeffdchang@gmail.com">jeffdchang@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> Hi Muthu, 1. Sorry, next time I will do that. 2. Yes I did adjust the multipliers because after several searches through codes, I could not locate where Impress extracts data specific to each template (eg. where does template Water get dimensions xx by xx for body, or Glacier xx by xx for title), and I didn't want to change the template layout files (.lyt), so I decided that the best place would be multipliers. Of course, I made sure that this was a reasonable choice, because I understood that all templates would be affected. From the looks of it, after reducing the height and width of the body, it seemed to eliminakernel imagete the oversized textbox leaking problems. Also, none of the other text boxes in any of the other slides look uncomfortably small, so I find it as a viable solution. (For those that do, consider the Master Page View, in which the Template has to make accommodations for the footer, date, slide # underneath). Lastly, if by blank template you mean the default template, there is no problem. There has been no problems I can see of after making the changes I did, apart from the bug I reported. 3. I realized that there were two sources for the observable problems. The first was that some of the outline/body dimensions for the templates were plain wrong and just too big. That was addressed in 2. But another problem is that the slide layout is based on the Master Page View Outline, and for some of them, the outline points were causing a problem. For example, if you like at the buggy Wine template, the outline/body leaks way to far below the slide. The reason is that when you go to Master Page view, the Ninth level of bullet point is jammed and squeezed, resulting in over-extending the outline text box to make room for it, hence the huge increase in height. If you eliminate the ninth level, the problem is reduced after leaving Master Page View. Originally I was going to remove the eighth and ninth level of the outline to solve this problem, but I decided to with 5-9 for test and forgot to reset it to remove 8-9. And since I think that rarely will some have to go to the eight level of bullet points in a presentation, once again this is a viable solution. Sorry for the confusion and ambiguity. I hope this clears things up and the patch is ok. Please reply if you see any more problems. Thanks, Jeffrey <div class="gmail_quote">On Wed, Aug 3, 2011 at 3:56 PM, Yifan Jiang <<a href="mailto:yfjiang@novell.com" target="_blank">yfjiang@novell.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> fyi -- Yifan Jiang Libreoffice / SuSE Contact: yifan - <a href="http://irc.freenode.net/libreoffice" target="_blank">irc.freenode.net/libreoffice</a> ============================================= <a href="http://www.libreoffice.org/" target="_blank">http://www.libreoffice.org/</a> <a href="http://www.documentfoundation.org/" target="_blank">http://www.documentfoundation.org/</a> ---------- Forwarded message ---------- From: Muthu Subramanian K <<a href="mailto:sumuthu@novell.com" target="_blank">sumuthu@novell.com</a>> To: jeffrey chang <<a href="mailto:jeffdchang@gmail.com" target="_blank">jeffdchang@gmail.com</a>> Date: Wed, 03 Aug 2011 12:38:03 +0530 Subject: Re: [Libreoffice] [PATCH] for Bug 32719 (jeffrey chang) Hi, Thank you for the patch. Assuming this is your first patch (or at-least one of the first few), I have a few suggestions: 1. It would nice if you could remove the test code commented - helps in reviewing quickly. 2. You have changed the multipliers in multiple locations - are you sure these don't affect the normal working? (say, having a blank template?) 3. It would also be nice if you could explain the reason for removing the content from STR_PRESOBJ_MPOUTLLAYER5 to STR_PRESOBJ_MPOUTLLAYER9 Will wait for your updates before pushing... Thanks again for your nice work... Regards, Muthu Subramanian -------------------------------------------------- Date: Mon, 1 Aug 2011 13:27:33 +0800 From: jeffrey chang <<a href="mailto:jeffdchang@gmail.com" target="_blank">jeffdchang@gmail.com</a>> Subject: [Libreoffice] [PATCH] for Bug 32719 To: <a href="mailto:libreoffice@lists.freedesktop.org" target="_blank">libreoffice@lists.freedesktop.org</a> Here is the patch for EasyHack 32719. I have also discovered another bug relating to Impress Templates, documented here: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=39705" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=39705</a> I am submitting this under the LGPLv3+/MPL 1.1 license. Thanks, -- --Jeffrey Chang _______________________________________________ LibreOffice mailing list <a href="mailto:LibreOffice@lists.freedesktop.org" target="_blank">LibreOffice@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a> </blockquote></div> -- --Jeffrey Chang _______________________________________________ LibreOffice mailing list <a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a> </blockquote></div> -- --Jeffrey Chang