HI Caolán<br><br>I had to add this patch to prevent the table boudaries crash issue that raised when one use the By property for GoLeftSel and GoRightSel.<br><br>The test case is (GoLeftSel)<br><br>sub Main<br>rem ----------------------------------------------------------------------<br>
rem define variables<br>dim document as object<br>dim dispatcher as object<br>rem ----------------------------------------------------------------------<br>rem get access to the document<br>document = ThisComponent.CurrentController.Frame<br>
dispatcher = createUnoService("com.sun.star.frame.DispatchHelper")<br><br>rem ----------------------------------------------------------------------<br>dim args1(0) as new com.sun.star.beans.PropertyValue<br>args1(0).Name = "ToPoint"<br>
args1(0).Value = "$E$7"<br><br>dispatcher.executeDispatch(document, ".uno:GoToCell", "", 0, args1())<br><br>rem ----------------------------------------------------------------------<br>dim args2(0) as new com.sun.star.beans.PropertyValue<br>
args2(0).Name = "By"<br>args2(0).Value = 10<br><br>dispatcher.executeDispatch(document, ".uno:GoLeftSel", "", 0, args2())<br><br>end sub<br><br><br><br><div class="gmail_quote">2011/7/29 Caolán McNamara <span dir="ltr"><<a href="mailto:caolanm@redhat.com">caolanm@redhat.com</a>></span><br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">On Fri, 2011-07-29 at 06:30 -0300, Olivier Hallot wrote:<br>
> Here is a patch to allow GoUpSel, GoDownSel, GoLeftsel,GoRightSel to<br>
> receive "By" property<br>
<br>
</div>Looks good.<br>
<div class="im"><br>
> a test file appended as well. Run Main macro to test patch<br>
><br>
> I left<br>
> SID_CURSORBLKDOWN_SEL<br>
> SID_CURSORBLKUP_SEL<br>
> SID_CURSORBLKLEFT_SEL<br>
> SID_CURSORBLKRIGHT_SEL<br>
><br>
> untouched because repetitions makes no sense to them AFAIK<br>
<br>
</div>I see that the pre-existing ::ExecuteCursor doesn't make a distinction<br>
for the Block selections, it just repeats them the same as non block. So<br>
I adjusted your patch to include them as well to be consistent between<br>
moving, and selecting. (hopefully I haven't cocked this up, Kohei, et.<br>
al. can double check it for me I guess)<br>
<br>
Pushed as calc:2a6f95014f3f8be561b4b67e9274a3cc24e2d08f (to master, so<br>
not in 3-4 stream), thanks for this.<br>
<font color="#888888"><br>
C.<br>
<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Olivier Hallot<br>Founder and Steering Commitee Member<br>The Document Foundation<br><br>