<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Perhaps it would be a good idea to add some comments to that code so that analysis is preserving for future generations of code archeologists :-) Seriously, I often do this because it saves me time later when I look at some code and think "why is it doing _that__???" Michael Meeks wrote: <blockquote cite="mid:1313659066.1806.277.camel@lenovo-w500" type="cite"> <pre wrap=""> On Thu, 2011-08-18 at 01:57 -0500, Norbert Thiebaud wrote: </pre> <blockquote type="cite"> <pre wrap="">Guards are used and badly abused in the code, especially with the infamous SolarMutex... anything that would make that code slower or fatter than it already is (with virtual functions and all), especially for corner-case 'you-are-about-to-die-anyway' scenario, is bad. </pre> </blockquote> <pre wrap=""> Right - throwing exceptions - or annotating methods as being able to throw exceptions for corner cases that are highly unlikely seems like just adding unwinding bloat for no major advantage. </pre> <blockquote type="cite"> <pre wrap="">so my opinion is, just let it be :-) </pre> </blockquote> <pre wrap=""> Ditto; good catch though Lionel - great to have some scrutiny of this sort of issue: no doubt there are plenty of things that can fail that are not handled correctly currently, and would be good to improve. Thanks for caring ! All the best, Michael. </pre> </blockquote> <hr>Disclaimer: <a href="http://www.peralex.com/disclaimer.html">http://www.peralex.com/disclaimer.html</a> </body> </html>