@Lionel , What is the QuadPart member of the structure? The high part? the low part? or another thing? Thanks in advance :) . <div class="gmail_quote">2011/9/12 Lionel Elie Mamane <<a href="mailto:lionel@mamane.lu">lionel@mamane.lu</a>> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">On Sun, Sep 11, 2011 at 10:04:52PM +0200, CaStarCo wrote: > I've created a second (very little too) patch to reduce the scope of a > variable. </div>> --- a/sal/osl/w32/file_dirvol.cxx > +++ b/sal/osl/w32/file_dirvol.cxx > @@ -60,7 +60,6 @@ extern "C" BOOL TimeValueToFileTime(const TimeValue *cpTimeVal, FILETIME *pFTime Thank you for your contribution to LibreOffice, it is most welcome. Looking at that function in that file, it needs a more thorough cleanup, and maybe other functions in that file and/or in other files in the same directory; see <a href="http://msdn.microsoft.com/en-us/library/ms724284%28v=VS.85%29.aspx" target="_blank">http://msdn.microsoft.com/en-us/library/ms724284%28v=VS.85%29.aspx</a>, in particular: It is not recommended that you add and subtract values from the FILETIME structure to obtain relative times. Instead, you should copy the low- and high-order parts of the file time to a ULARGE_INTEGER structure, perform 64-bit arithmetic on the QuadPart member, and copy the LowPart and HighPart members into the FILETIME structure. Do not cast a pointer to a FILETIME structure to either a ULARGE_INTEGER* or __int64* value because it can cause alignment faults on 64-bit Windows. It would be best to look at every place that FILETIME is used in that directory. Just in case you want to volunteer for that cleanup :) When you send a patch, could you please confirm the patch is licensed under MPL1.1/LGPLv3+? To make things easier, you can do a one-time blanket "all my patches" thing if you wish, sort of common to do that. Best Regards, -- Lionel </blockquote></div> -- - Per la llibertat del coneixement - - Per la llibertat de la ment... -