Hello Caolan, Michael,<br><br><div class="gmail_quote">2011/9/21 Michael Meeks <span dir="ltr"><<a href="mailto:michael.meeks@novell.com">michael.meeks@novell.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
On Wed, 2011-09-21 at 09:50 +0100, Caolán McNamara wrote:<br>
> So I've now added a timer listener to our cppunit launcher to tell us<br>
> how long each test takes[1] and indeed it takes about 70ms to load a<br>
> .xls, 370ms for an equivalent .ods and about 500ms(?!) for an<br>
> equivalent .xlsx<br>
<br>
</div> Ooh :-) pretty numbers indeed, how can I reproduce them ? I notice they<br>
didn't go to the console (which is a shame), and couldn't see them in<br>
the sc_filters_test.log file either (oddly).<br></blockquote><div><br>I'm not really surprised by these numbers - maybe that xls is that fast - but xlsx and ods use way too much slow uno calls. <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im"><br>
> In an ideal world I imagine the best spent effort would be on improving<br>
> the import speed for .ods and .xlsx, seeing as that improves the<br>
> real-world case too.<br>
<br>
</div><br></blockquote><div><br>I don't agree here. In my opinion it would be best to have them seperate but only test universal-content.ods and maybe one or two other major features in the normal build target. All the other files can be tested in the proposed target. Mixing all features in one or two files results in a big clump that can never be extended. My idea was to have a file for every major feature in each of the three main filters. And I don't think that using only one filter is a good idea either. We had too many examples in 3-4 where changing parts of a feature resulted in misbehaviour in just one filter code.<br>
I totally agree with you that it is too much time spend in a normal build for unit tests but at least a calc dev should run all of them before pushing his changes.<br><br>Regards,<br>Markus<br></div></div><br>