Hi all,<br><br>I removed some uses of SvStringsSortDtor, which is listed in<br><a href="http://wiki.documentfoundation.org/Easy_Hacks#Easy_Hacks">http://wiki.documentfoundation.org/Easy_Hacks#Easy_Hacks</a><br><br>There's uses of SvStringsSortDtor which I couldn't understand, so I left them untouched.<br>
<br>They are sc/source/filter/html/htmlexp.cxx and sw/source/filter/writer/writer.cxx,<br>which are very similar; two SvStringsSortDtors (pSrcArr and pDstArr) are used in pair.<br><br>Looking at htmlexp.cxx:1320, pSrcArr is used to lookup for an index of a string, and then the index is applied to pDstArr.<br>
In my understanding indices of two arrays are unrelated, because arrays are sorted by their respective contents.<br><br><blockquote style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;" class="gmail_quote">
if( pSrcArr->Seek_Entry( &rFileNm, &nPos ))<br> {<br> rFileNm = *(*pDestArr)[ nPos ];<br> return sal_True;<br> }<br></blockquote><br>where rFileNm is of type String&.<br clear="all">
<br><br>I guess what is intended here is mapping of strings, from pSrcArr to pDstArr (with incorrect implementation).<br>If so, I'll replace them with std::map<String, String>.<br><br>How do you think?<br><br>Cheers,<br>
<br>-- <br>Daisuke Nishino<br>