Caolán, Thank you for your comments. Here is the patch. Cheers, <div class="gmail_quote">On Wed, Nov 9, 2011 at 12:01 AM, Caolán McNamara <<a href="mailto:caolanm@redhat.com">caolanm@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> <div class="im">On Tue, 2011-11-08 at 22:43 +0900, Daisuke Nishino wrote: > Hi all, > > I removed some uses of SvStringsSortDtor, which is listed in > <a href="http://wiki.documentfoundation.org/Easy_Hacks#Easy_Hacks" target="_blank">http://wiki.documentfoundation.org/Easy_Hacks#Easy_Hacks</a> </div>Looks good (Initially I thought there was a few vectors with potential dups in them before I scrolled down a bit to see the sort, unique, erase :-)). So pushed, thanks for these. <div class="im"> > Looking at htmlexp.cxx:1320, pSrcArr is used to lookup for an index of > a string, and then the index is applied to pDstArr. > In my understanding indices of two arrays are unrelated, because > arrays are sorted by their respective contents. </div>Yeah, it's puzzling. Original code doesn't look right at all. <div class="im"> > I guess what is intended here is mapping of strings, from pSrcArr to > pDstArr (with incorrect implementation). </div>The intent seems fairly clear anyway, so it looks like a std::map identifier->filename is what's wanted. C. </blockquote></div> -- Daisuke Nishino