<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 11/11/11 08:06, Winfried Donkers wrote:
<blockquote
cite="mid:F0865CA4B825D94B9D4BBB19F4E7DF456A6A75E022@DCI-FS-01.dci-electronics.local"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:Consolas;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
MsoChpDefault
{mso-style-type:export-only;}
@page Section1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.Section1
{page:Section1;}
-->
</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="Section1">
<p class="MsoNormal">First tiny contribution.<o:p></o:p></p>
<p class="MsoNormal">Translated comments, also renamed define
MAX_COL_HEIGHT to
MAX_ROW_HEIGHT.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoPlainText">This patch is and future patches will be
contributed under
the LGPLv3+ / MPL.</p>
</div>
</blockquote>
Erm, I think the attached patch is not the intended one right (
patch attached is something already committed )?<br>
<blockquote
cite="mid:F0865CA4B825D94B9D4BBB19F4E7DF456A6A75E022@DCI-FS-01.dci-electronics.local"
type="cite">
<div class="Section1">
<p class="MsoPlainText"><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">By the way,<o:p></o:p></p>
<p class="MsoNormal">should comments like<o:p></o:p></p>
<p class="MsoNormal"> case FID_INS_COLUMN: //
insert columns<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> case
SID_COPY: // Kopieren
(translate to copy)<o:p></o:p></p>
<p class="MsoNormal">be translated or removed? I don't see any
additional value
in these comments<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
The first imo has some value, INS_COLUMN might not be immediately
obvious as meaning insert columns especially to non-native english
speakers. The second I would delete, I don't think there is a hard
and fast rule, just use common sense I guess<br>
<br>
Noel <br>
<br>
</body>
</html>