<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
forgot to change the subject line to PUSHED, also the commit is here<br>
<br>
<a class="moz-txt-link-freetext" href="http://cgit.freedesktop.org/libreoffice/core/commit/?id=98a10b638a645776d14049b8fb12a87b80b6eb3b">http://cgit.freedesktop.org/libreoffice/core/commit/?id=98a10b638a645776d14049b8fb12a87b80b6eb3b</a><br>
<br>
thanks,<br>
<br>
Noel<br>
On 11/11/11 15:02, Noel Power wrote:
<blockquote cite="mid:4EBD38F3.9080809@suse.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 11/11/11 12:56, Winfried Donkers wrote:
<blockquote
cite="mid:F0865CA4B825D94B9D4BBB19F4E7DF456A6A75E06D@DCI-FS-01.dci-electronics.local"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:Consolas;
color:black;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.Section1
{page:Section1;}
-->
</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="Section1">
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">(reply to list as well<span
style="color:#1F497D"> -together with attachment-</span>
is better, of course)<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">>>First tiny contribution.<o:p></o:p></p>
<p class="MsoNormal">>>Translated comments, also renamed
define MAX_COL_HEIGHT to MAX_ROW_HEIGHT.<o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span
style="font-size:12.0pt; font-family:"Times New
Roman","serif"">>Erm, I think the
attached patch is not the intended one right ( patch
attached is something already committed )?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color: rgb(31, 73, 125);">I
did it with 'git commit -a' followed by 'git format-patch
filename', as read somewhere in this list. That may have
been the wrong thing to do...</span></p>
</div>
</blockquote>
No, that is the correct thing to do, since you were able to create
your patch with git diff it appears that you didn't actually
commit your changes ( and git format-patch only works with commits
). Probably your commit failed and you didn't notice the error
message.<br>
<br>
There is however another problem, if you look at your attached
diff you will notice that that complete contents of
sc/source/ui/view/cellsh3.cxx are marked as removed and then all
lines ( + your additions ) added into that file. What has happened
*I think* is that whatever editor you are using is inserting
windows style (CR)(LF) line endings. The diff tool then thinks
that each line in the file has been replaced. You need to teach
your editor not to do that ( most editors should have a setting
for that ). <br>
<blockquote
cite="mid:F0865CA4B825D94B9D4BBB19F4E7DF456A6A75E06D@DCI-FS-01.dci-electronics.local"
type="cite">
<div class="Section1">
<p class="MsoNormal"><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">The
attachment now is made with 'git diff > filename'.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I hope this
one's better...<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I am sorry of
making a mess of it!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
</div>
</blockquote>
not at all, just teething problems :-) thanks for the nice patch.<br>
Finally can you confirm you contribution is under LGPLv3+ / MPL
license<br>
<br>
thanks again,<br>
Noel<br>
</blockquote>
<br>
</body>
</html>