Hello Philipp,<br><br>Your inputs made sense, thanks for reviewing. Herewith the updates. As before GPL/MPL is valid.<br><br>Let me find another target...<br><br>Luc<br><br><div class="gmail_quote">2011/11/19 Philipp Weissenbacher <span dir="ltr"><<a href="mailto:p.weissenbacher@gmail.com">p.weissenbacher@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hoi Luc, all,<br>
<br>
Not sure if that really matters, but I think that<br>
// Klammerung, da in diesem Handler das Window zerstoert werden darf<br>
// Parentheses, as in this handler the window could be destroyed<br>
"could" should be "can".<br>
<br>
On line 925 (in the patch):<br>
I would translate it like this:<br>
If the Overlap-Window has changed, we need to test whether<br>
OverlapWindows that had the<br>
Child window as their parent need to be put into the window hierarchy.<br>
<br>
Line 992/993:<br>
I think that<br>
If it is a SystemWindow it automatically pops up on top of all other<br>
windows if needed.<br>
is a bit clearer.<br>
<br>
Line 1083:<br>
I think you meant "was sent once"; I think "... already sent" is more<br>
appropriate.<br>
<br>
Otherwise very nice patch! And let's hang in there and get all the<br>
German comments out!<br>
<br>
Cheers,<br>
Philipp<br>
<div><div class="h5"><br>
On 19 November 2011 00:41, Luc Castermans <<a href="mailto:luc.castermans@gmail.com">luc.castermans@gmail.com</a>> wrote:<br>
> Gents,<br>
><br>
> Triggered by Lionel I attacked this close to 10k lines beast and translated<br>
> comments from German to English.<br>
><br>
> My contribution is under GPL/MPL. as my last and future ones.<br>
><br>
> thanks,<br>
><br>
> --<br>
> Luc Castermans<br>
> mailto:<a href="mailto:luc.castermans@gmail.com">luc.castermans@gmail.com</a><br>
><br>
</div></div>> _______________________________________________<br>
> LibreOffice mailing list<br>
> <a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a><br>
><br>
><br>
</blockquote></div><br><br clear="all"><br>-- <br>Luc Castermans<br>mailto:<a href="mailto:luc.castermans@gmail.com">luc.castermans@gmail.com</a><br>