<div dir="ltr"><div class="gmail_quote">On Thu, Nov 24, 2011 at 8:28 PM, Andras Timar <<a href="mailto:timar74@gmail.com" target="_blank">timar74@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div><div>Hi Kaplan, 2011/11/24 Lior Kaplan <<a href="mailto:kaplanlior@gmail.com" target="_blank">kaplanlior@gmail.com</a>>: > On Thu, Nov 24, 2011 at 1:14 PM, Lior Kaplan <<a href="mailto:kaplanlior@gmail.com" target="_blank">kaplanlior@gmail.com</a>> wrote: >> >> >> On Thu, Nov 24, 2011 at 1:05 PM, Andras Timar <<a href="mailto:timar74@gmail.com" target="_blank">timar74@gmail.com</a>> wrote: >>> >>> Hi Kaplan, >>> >>> 2011/11/24 Lior Kaplan <<a href="mailto:kaplanlior@gmail.com" target="_blank">kaplanlior@gmail.com</a>>: >>> > Hi, >>> > >>> > While translating some scp2 strings for 3.5 I notice duplicate strings >>> > which >>> > looks weird (e.g. "Installs the Tamil user interface"). >>> > >>> > I checked the sources and notice this is because we have two locales >>> > for >>> > Tamil: >>> > >>> > [STR_NAME_MODULE_LANGPACK_TA] >>> > en-US = "Tamil" >>> > >>> > [STR_DESC_MODULE_LANGPACK_TA] >>> > en-US = "Installs the Tamil user interface" >>> > >>> > [STR_NAME_MODULE_LANGPACK_TA_IN] >>> > en-US = "Tamil" >>> > >>> > [STR_DESC_MODULE_LANGPACK_TA_IN] >>> > en-US = "Installs the Tamil user interface" >>> > >>> > Do we really support two locales or this is a mistake? If we do support >>> > two >>> > locales, the users should have a way to differentiate between the two. >>> > >>> >>> We don't support ta_IN, only ta. In fact those lines could be removed >>> from scp2 (there are more to clean up I suppose). >>> For supported UI locales see >>> <a href="http://opengrok.libreoffice.org/xref/core/solenv/inc/langlist.mk" target="_blank">http://opengrok.libreoffice.org/xref/core/solenv/inc/langlist.mk</a> >>> >> >> Good to know. I'll do the clean up and send a patch... >> > > Attaching two patches to clean the help and language pack translation > strings. Also a small clean up patch for the <a href="http://langlist.mk" target="_blank">langlist.mk</a> file to have it > sorted. > > Dictionary list is verified and is updated (no changes needed). > </div></div>Please push 0001 and 0003. In 0002 you were a bit greedy in deleting stuff. :) Save at least qtz. I would save all languages in helppack file which have an UI pack. So I don't have to remember to re-add them and translators don't have to re-translate them when a language team decides to translate the help, too. </blockquote><div> Fair enough. Attaching an updated patch instead of #0002... This time removing only languages without a translation, not without a help translation. qtz saved... ooops. Kaplan </div></div></div>