<div class="gmail_quote">On Mon, Nov 28, 2011 at 6:42 PM, Stephan Bergmann <span dir="ltr"><<a href="mailto:sbergman@redhat.com" target="_blank">sbergman@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On 11/27/2011 08:57 AM, Daisuke Nishino wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Exposing functioin pointers to outside is not a good practice I think.<br>
This patch encapsulates them.<br>
Also, since fnLeaveSelect is called from only one location, I eliminated<br>
the indirection.<br>
</blockquote>
<br></div>
Great, thanks. Pushed (I simplified the "this->*this->" calls by removing the redundant second "this->").<br>
<br></blockquote><div><br>Thanks!<br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I do not find your license statement at <<a href="http://wiki.documentfoundation.org/Development/Developers" target="_blank">http://wiki.documentfoundation.org/Development/Developers</a>>, can you add it there (I assume you contribute under LGPLv3+/MPL 1.1+)?<br clear="all">
</blockquote><div><br>Ah, I posted the license statement on Nov 25:<br><br>On Fri, Nov 25, 2011 at 2:10 AM, Daisuke Nishino <span dir="ltr"><<a href="mailto:niboshi000@gmail.com">niboshi000@gmail.com</a>></span> wrote:<br>
<blockquote style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;" class="gmail_quote"><br></blockquote><span></span><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
<span>Lisence:</span><br><span>All my past and future contributions </span><span>(including this one) </span><span>to LibreOffice are under </span>LGPLv3+/MPL until further notice.<br></blockquote><div><br>I thought I don't need to write the statement once I have posted the above.<br>
Should I edit the wiki page, or do I need to write it in every posts?<br>p.s. I noticed a typo now :(<br>
<br></div></div></div>Thanks,<br><br>-- <br>Daisuke Nishino<br>