<div dir="ltr"><div class="gmail_quote">On Sat, Jan 7, 2012 at 7:39 PM, Ivan Timofeev <span dir="ltr"><<a href="mailto:timofeev.i.s@gmail.com">timofeev.i.s@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
06.01.2012 20:57, Lior Kaplan пишет:</blockquote><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The strings are coming from svx/source/items/svxitems.src<br>
(RID_SVXITEMS_PAGE_LAND_FALSE and RID_SVXITEMS_PAGE_USAGE_LEFT), and<br>
the only reference for them I found is svx/source/items/pageitem.cxx<br>
<br>
I compared it to the code of other items in the page, and didn't<br>
find any space addition the other strings... any idea why in this<br>
case there's a missing space?<br>
</blockquote>
<br></div>
Bug? The author forgot to add the delimiter?<br>
<br>
if ( bLandscape )<br>
rText += SVX_RESSTR(RID_SVXITEMS_PAGE_<u></u>LAND_TRUE);<br>
else<br>
rText += SVX_RESSTR(RID_SVXITEMS_PAGE_<u></u>LAND_FALSE);<br>
- rText += GetUsageText( eUse );<br>
+ String aUsageText = GetUsageText( eUse );<br>
+ if (aUsageText.Len())<br>
+ {<br>
+ rText += cpDelim;<br>
+ rText += aUsageText;<br>
+ }<br>
return SFX_ITEM_PRESENTATION_<u></u>NAMELESS;<div class="im"><br>
}<br></div></blockquote></div><br>Cool (: <br><br>This fix is also relevant a few lines bellow, adding a patch to include them both. <br><br>Also, including [REVIEW] in the subject.<br><br>Kaplan<br></div>