<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#ffffff"> Am 12.01.2012 17:17, schrieb Olivier Hallot: <blockquote cite="mid:4F0F07A1.90003@documentfoundation.org" type="cite"> <pre wrap="">-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Thank you Christina for the patch. It look like your patch is ok, with respect to the logic inversion. A build should indicate if the method isEmpty() is valid for the right object (e.g. it is not valid for OUStringBuffer or Sequence). </pre> </blockquote> I've built it successfully and found out that O(U)StringBuffer has no isEmpty() this morning  :-) <blockquote cite="mid:4F0F07A1.90003@documentfoundation.org" type="cite"> <pre wrap=""> Do you mind to 1) update bug fdo43460 with your (pushed) patch? </pre> </blockquote> You mean just add an comment which mentions the directory I've been working in? Of course can I do that. When I'm finished with vcl or already now with that little bit? <blockquote cite="mid:4F0F07A1.90003@documentfoundation.org" type="cite"> <pre wrap=""> 2) complete module vcl/ with these replacements? I will mark it as yours in my control file. Attached an exerpt of the files and lines to look at. </pre> </blockquote> As time permits. Probably interleaved with the ByteString replacement. Christina <blockquote cite="mid:4F0F07A1.90003@documentfoundation.org" type="cite"> <pre wrap=""> Regards Olivier Em 12-01-2012 12:29, Chr. Rossmanith escreveu: </pre> <blockquote type="cite"> <pre wrap="">Hi, while replacing ByteString with OString I came across some getLength() calls which might be replaced with isEmpty(). Hope Olivier won't be annoyed :-) Some reviewing would be nice to be sure the logic didn't get inverted accidently.I have git push access - so reviewing would be sufficient. Christina _______________________________________________ LibreOffice mailing list <a class="moz-txt-link-abbreviated" href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/libreoffice">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a> </pre> </blockquote> <pre wrap=""> - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - <a class="moz-txt-link-freetext" href="http://enigmail.mozdev.org/">http://enigmail.mozdev.org/</a> iQEcBAEBAgAGBQJPDwehAAoJEJp3R7nH3vLxl3cH/0qtyGFDI44WaSWr5XVKgU7n oGzqcz/DBAuaDRr7NZnHp2rerAXNur1r6M1gVL+yyO/DsLxwnDdUAQsUdwcZspzR zckK5D8l9q6oD/+o16Ismr5/r+E9Fn5Jz/MH+ER+nqslZe5k138eJZH2L5KrwR7i J1Uq5ZIZHa+Q9+aWCBeRVpb8RU+VnBx2nVBUQ98ovQ/ShDCE3SNGOwNSQAQtz8si LzXd4MfTmFZJSk4DwlTXXOAoXcYn6rwRdxr2DsyOa/faOeBwWrBVLrKfGN4Bl1rn MYEDLvQqZQ7T3FHik4aOHVUmvfYvJKaP1X+oAcHgM5WJpHhYmURf1wAMY8QgrI4= =tufN -----END PGP SIGNATURE----- </pre> <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ LibreOffice mailing list <a class="moz-txt-link-abbreviated" href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/libreoffice">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a> </pre> </blockquote> </body> </html>