<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> On 02/02/12 18:17, Muhammad Haggag wrote: <blockquote cite="mid:CAH=kDd1o4kb8QROqVwCcBdsfDXQY5vr-bOfUZF6urSgOb0c3xw@mail.gmail.com" type="cite"> <div dir="ltr"> <div class="gmail_quote">On Thu, Feb 2, 2012 at 5:13 PM, Muhammad Haggag <span dir="ltr"><<a moz-do-not-send="true" href="mailto:mhaggag@gmail.com">mhaggag@gmail.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr"> <div> <div class="gmail_quote"> <div class="im">On Thu, Feb 2, 2012 at 2:01 PM, Noel Power <span dir="ltr"><<a moz-do-not-send="true" href="mailto:nopower@suse.com" target="_blank">nopower@suse.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div> <div>very nice patch, looking at the spec I agree and this looks like a credible fix for me so pushed to master. Look forward to more like this, thanks</div> </div> <br> </blockquote> </div> <div>Thanks for the review! If you'd pardon my absolute noobiness, do I have access to push to master? I checked out the code from the anongit repository.</div> </div> </div> </div> </blockquote> <div><br> </div> <div>Ah, disregard my question--I thought you were asking me to push. Now I see that you were saying you've already pushed it. Another question though, what to do about the bug? Will you resolve or close it, or should I do that? Or is it the tester(s)?</div> <div> </div> <div>Regards,</div> <div>--Muhammad</div> </div> </div> </blockquote> sorry, missed this mail, I marked it as fixed, I am not sure about the 'hard' rules about resolving a bug, generally I mark my own bugs as resolved after I commit a fix and/or test. I think if someone reviews a patch ( that is addresses a specific bug ) then they probably should mark the bug as well after they commit the patch ( and I forgot to do that ;-) )<br> <br> thanks again<br> <br> Noel<br> </body> </html>