<br><br><div class="gmail_quote">2012/3/2 Thomas Collerton <span dir="ltr"><<a href="mailto:tom.coll91@gmail.com">tom.coll91@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi, thanks for the tip. This is an improved (hopefully) version of the patch =)<div>Cheers!<div><div class="h5"><br><br><div class="gmail_quote">2012/2/29 Michael Meeks <span dir="ltr"><<a href="mailto:michael.meeks@suse.com" target="_blank">michael.meeks@suse.com</a>></span><br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi there,<br> <div><br> On Wed, 2012-02-29 at 11:58 +0100, Thomas Collerton wrote:<br> > this patch accomplishes what the EasyHack requests =)<br> <br> </div> Thanks - pushed it :-)<br> <br> Personally, I'd have split out the 'write_args' type functionality<br> below that into a method of it's own, and added a read_args / write_args<br> pair - so that all the I/O is in perl rather than a system forked<br> whatnot but ... ! :-) I'm paranoid too - we should have cp around on all<br> systems that run this.<br> <br> Ta. very much, can you close the bug ?<br> <br> Thanks,<br> <br> Michael.<br> <span><font color="#888888"><br> --<br> <a href="mailto:michael.meeks@suse.com" target="_blank">michael.meeks@suse.com</a> <><, Pseudo Engineer, itinerant idiot<br> <br> </font></span></blockquote></div><br></div></div></div> </blockquote></div><br>