<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi David, <br>
<br>
cpputools/prj/makefile.mk was missing in my patch, and this broke
the build, fixed:<br>
<br>
David<br>
<br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject: </th>
<td>Re: [PATCH][REVIEW] gbuild conversion: module cpputools</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
<td>Mon, 02 Apr 2012 22:32:28 +0200</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
<td>David Ostrovsky <a class="moz-txt-link-rfc2396E" href="mailto:david.ostrovsky@gmx.de"><david.ostrovsky@gmx.de></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td>David Tardon <a class="moz-txt-link-rfc2396E" href="mailto:dtardon@redhat.com"><dtardon@redhat.com></a>,
<a class="moz-txt-link-abbreviated" href="mailto:libreoffice@lists.freedesktop.org">libreoffice@lists.freedesktop.org</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi David,<br>
<br>
thank you for your comments. Here is another try.<br>
As you haven't merged feature/gbuild_components branch to master<br>
I let "gb_Executable_add_api" in place: <br>
<br>
As you suggested the next modules to convert are:<br>
idlc, l10ntools, rdbmaker, soltools, unodevtools <br>
<br>
David<br>
<br>
PS:<br>
contribution notice.<br>
<br>
<span
style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">All
of my past and future contributions to the LibreOffice project are</span><br
style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">
<span
style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">under
LGPLv3+/GPLv3+/MPL until further notice.</span><br>
<br>
On 01.04.2012 17:10, David Tardon wrote:
<blockquote cite="mid:20120401151042.GE30231@localhost.localdomain"
type="cite">
<pre wrap="">On Sun, Apr 01, 2012 at 04:32:16PM +0200, David Ostrovsky wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
this patch convert cpputools module to gbuild
</pre>
</blockquote>
<pre wrap="">
Hi, David,
it is a good start, but unfortunately not quite correct yet. See the
comments below.
</pre>
<blockquote type="cite">
<pre wrap="">From f44e44974d14be4482f1676600b8b3c407f60684 Mon Sep 17 00:00:00 2001
From: David Ostrovsky <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:David.Ostrovsky@gmx.de"><David.Ostrovsky@gmx.de></a>
Date: Sun, 1 Apr 2012 16:24:31 +0200
Subject: [PATCH 2/2] gbuild conversion: cpputools module
+$(eval $(call gb_Executable_add_api,regcomp,\
+ udkapi \
+))
</pre>
</blockquote>
<pre wrap="">That one is not obvious, but it is wrong anyway. The original makefile
uses headers generated with cppumaker -C, as to not require unoapi.rdb
at runtime. I am afraid you will have to wait a few days till
feature/gbuild_components is integrated into master. Then you should use
gb_Executable_add_internal_comprehensive_api .
</pre>
<blockquote type="cite">
<pre wrap="">+
+$(eval $(call gb_Executable_add_linked_libs,regcomp,\
+ basegfx \
</pre>
</blockquote>
<pre wrap="">This is most certainly useless. I cannot imagine why would the regcomp
executable need a graphic library .-)
Another thing that is not obvious (and I think even documented anywhere
at libreoffice) is that we want the module integrated into the old build
system as well. To do that, just copy prj/makefile.mk from some already
converted module, remove all lines containing "nmake" from prj/build.lst
(actually I suppose that could be "everything but first two lines") and
add something like
pt cpputools\prj nmake - all pt_prj NULL
. Also remove content from prj/d.lst .
Also, after you are done, you can remove the now useless makefile.mk
files (except the one in prj, of course).
D.
_______________________________________________
LibreOffice mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/libreoffice">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a>
</pre>
</blockquote>
<br>
<br>
</body>
</html>