<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 03.05.2012 13:23, Thorsten Behrens wrote:
<blockquote cite="mid:20120503112329.GV3038@thinkpad.thebehrens.net"
type="cite">
<pre wrap="">David Ostrovsky wrote:
</pre>
<blockquote type="cite">
<pre wrap="">5.
-.IF "$(OS)" == "MACOSX" && "$(CPU)" == "P" && "$(COM)" == "GCC"
-# There appears to be a GCC 4.0.1 optimization error causing
_<a class="moz-txt-link-freetext" href="file:good()">file:good()</a> to
-# report true right before the call to writeOut at
HelpLinker.cxx:1.12 l. 954
-# but out.good() to report false right at the start of writeOut at
-# HelpLinker.cxx:1.12 l. 537:
-NOOPTFILES=\
- $(OBJ)$/HelpLinker.obj \
- $(SLO)$/HelpLinker.obj
-.ENDIF
this was dropped.
Do we still need it? If uncertain, please activate it.
</pre>
</blockquote>
<pre wrap="">Hi Cloph, I think that was from you? What's your current version on
PPC?
</pre>
</blockquote>
Actually I activated it again, because my reviewer said I have to.<br>
I attached the new patch.<br>
Gerrit url remains the same: <a class="moz-txt-link-freetext" href="https://gerrit.libreoffice.org/#/c/105/">https://gerrit.libreoffice.org/#/c/105/</a>.<br>
<br>
Gerrit really rocks! <br>
With recently activated Change Id git trigger, this is as simple as
commit, rebase -i/squish, push - cycle ...<br>
and a new Patch Set version in the _same_ gerrit patch request is
created.<br>
It would be even cooler, if somebody would throw their tinderboxen
against it (refs/for/head branch)<br>
(especially with -Werror).<br>
<br>
One problem seen so far with gerrit, is not visibility of entered
comments for deleted files.<br>
To reproduce: open side by side review for deleted file, say <a
href="https://gerrit.libreoffice.org/#/c/105/5/l10ntools/source/help/makefile.mk"
class="gwt-InlineHyperlink">l10ntools/source/help/makefile.mk</a>.<br>
Enter some comments on random line there and save your draft. Nobody
can see it.<br>
Is this a gerrit bug? Workaround would be to enter comments in
review message itself in that case.<br>
<br>
Ciao<br>
David<br>
<br>
@Michal Stahl: thank you very mch for your review and solution
suggestions for found problems!<br>
<br>
</body>
</html>