I also like to avoid C-style string handling, but valueOf() doesn't support unsigned integers (it should support all C++ integer types), and converting to sal_Int64 didn't come into my mind.<br>Why did you extend the comment: "// converting value to unsigned <i>and limit to 2 or 4 byte representation</i>"? GetInteger() and GetLong() return sal_Int16 and sal_Int32, respectively, so the static_casts only convert them to unsigned.<br>
<br>Uray M. János<br><br><div class="gmail_quote">On Tue, Jul 31, 2012 at 3:38 PM, Noel Power <span dir="ltr"><<a href="mailto:nopower@suse.com" target="_blank">nopower@suse.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Ok, pushed now and also with a further tweak to avoid sprintf and the hardcoded buffersize ( 'cause 17 is too big anyway ) <a href="http://cgit.freedesktop.org/libreoffice/core/commit/?id=02a7dfb729799f9e1437a718951566640d0fde02" target="_blank">http://cgit.freedesktop.org/libreoffice/core/commit/?id=02a7dfb729799f9e1437a718951566640d0fde02</a><span class="HOEnZb"><font color="#888888">l<br>
</font></span></blockquote></div><br>