<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 02/08/12 15:31, Noel Power wrote:<br>
</div>
<blockquote cite="mid:501A8F34.1040205@suse.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi János,<br>
<br>
On 31/07/12 12:34, János Uray wrote:<br>
</div>
<blockquote
cite="mid:CAKR3yxyLsp12N0enHm0b5Fdcd6m0N=pnJ=ZTaekdsjYh5ZD2UA@mail.gmail.com"
type="cite">Again? Oh, yes.<br>
Now here it is.<br>
<br>
<div class="gmail_quote">On Tue, Jul 31, 2012 at 11:10 AM, Noel
Power <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:nopower@suse.com" target="_blank">nopower@suse.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>Hi János<br>
you forgot to attach the patch :-) <br>
<div>
<div class="h5"> <br>
On 30/07/12 19:04, János Uray wrote:<br>
</div>
</div>
</div>
<blockquote type="cite">
<div>
<div class="h5">This patch solves this bug: <a
moz-do-not-send="true"
href="https://bugs.freedesktop.org/show_bug.cgi?id=47907"
target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=47907</a><br>
<br>
The text was flickering because Window::Invalidate()
clears the client area by default. To prevent this,
I've added an INVALIDATE_NOERASE parameter to
Invalidate() calls.<br>
On the other hand, the background still needed to be
erased outside the text: the indentation space and
the rest of the line.<br>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
seems to work better :-), imho still is not as smooth as 3.4, I
would love to know *why* we get this behaviour now in >=3.5, is
something triggering Resize() more often now ( and why indeed is
Resize even called when scrolling ). Additionally I am a but
nervous about changes to the TextEngine ( a piece of code I have
no familiarity with at all ). Saying that the change you made
seems quite small ( despite the confusing diff due to the
whitespace changes ) I suppose it is the last part of the patch
that is really necessary. But still it just feels wrong that we
need to tweak the TextEngine and I wonder are we correcting a side
affect rather than fixing the root cause<br>
</blockquote>
well it seems that<br>
<br>
--- a/basctl/source/basicide/baside2b.cxx<br>
+++ b/basctl/source/basicide/baside2b.cxx<br>
@@ -682,7 +682,6 @@ void EditorWindow::Notify( SfxBroadcaster&
/*rBC*/, const SfxHint& rHint )<br>
( 0,
pModulWindow->GetBreakPointWindow().GetCurYOffset() -
pEditView->GetStartDocPos().Y() );<br>
pModulWindow->GetLineNumberWindow().DoScroll<br>
( 0,
pModulWindow->GetLineNumberWindow().GetCurYOffset() -
pEditView->GetStartDocPos().Y() );<br>
- pModulWindow->Invalidate();<br>
}<br>
else if( rTextHint.GetId() == TEXT_HINT_TEXTHEIGHTCHANGED )<br>
{<br>
<br>
<br>
solves the problem, I see no side affects, however since you have
proved you are quite adept and talented at handling complicated
drawing bits, notice if you scroll the window ( by dragging the
scroll bar ) if you have the linenumbers enabled they flash and
flicker and even disappear while scrolling, it would be great to get
than nice and smooth <br>
<br>
Noel<br>
</body>
</html>