<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hej Miklos,<br>
<br>
i added review command to git-review:<br>
<br>
<a class="moz-txt-link-freetext" href="https://review.openstack.org/17423">https://review.openstack.org/17423</a><br>
<br>
Now you can review gerrit patch without using web browser, and even
add multiline <br>
comment message in your favorite editor, i guess vim, or whatever
GIT_EDITOR is set ;-)<br>
<br>
Enjoy<br>
David<br>
<div class="moz-forward-container"><br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
</th>
<td>[Bug 1021750] Re: add gerrit review command</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
<td>Mon, 03 Dec 2012 23:00:33 -0000</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
<td>OpenStack Hudson <a class="moz-txt-link-rfc2396E" href="mailto:1021750@bugs.launchpad.net"><1021750@bugs.launchpad.net></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Reply-To:
</th>
<td>Bug 1021750 <a class="moz-txt-link-rfc2396E" href="mailto:1021750@bugs.launchpad.net"><1021750@bugs.launchpad.net></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td><a class="moz-txt-link-abbreviated" href="mailto:d.ostrovsky@gmx.de">d.ostrovsky@gmx.de</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>Fix proposed to branch: master
Review: <a class="moz-txt-link-freetext" href="https://review.openstack.org/17423">https://review.openstack.org/17423</a>
** Changed in: git-review
Status: New => In Progress
--
You received this bug notification because you are subscribed to the bug
report.
<a class="moz-txt-link-freetext" href="https://bugs.launchpad.net/bugs/1021750">https://bugs.launchpad.net/bugs/1021750</a>
Title:
add gerrit review command
Status in Git Review:
In Progress
Bug description:
it would be nice to have also wraper for gerrit review command:
<a class="moz-txt-link-freetext" href="http://gerrit-documentation.googlecode.com/svn/Documentation/2.4.2/cmd-review.html">http://gerrit-documentation.googlecode.com/svn/Documentation/2.4.2/cmd-review.html</a>
Because this tool already named review may be it can be renamed to
git-gerrit.
The guys from #gerrit freenode channel didn't understand what git-
review tool all about (as we tried to explain them) and have thought,
that it can only review the gerrit patches from command line.
Ironically that featuire ist still missing.
With this verb review in place (after renaming) the workflow would
like something like that:
git gerrit download c0ff33
look around
git gerrit review review --code-review +2 c0ff33
To see how other did it in python:
<a class="moz-txt-link-freetext" href="https://gitorious.org/querrit/querrit">https://gitorious.org/querrit/querrit</a>
and in bash:
<a class="moz-txt-link-freetext" href="http://cgit.freedesktop.org/libreoffice/core/tree/logerrit">http://cgit.freedesktop.org/libreoffice/core/tree/logerrit</a>
To manage notifications about this bug go to:
<a class="moz-txt-link-freetext" href="https://bugs.launchpad.net/git-review/+bug/1021750/+subscriptions">https://bugs.launchpad.net/git-review/+bug/1021750/+subscriptions</a>
</pre>
<br>
<br>
</div>
<br>
</body>
</html>