<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> On 27/12/2012 19:36, Kohei Yoshida wrote: <blockquote cite="mid:CAKyzJ7qng0cROmG1BDiAWU4dvHoT3QQp8v=-o8PW8ofLmCJWYA@mail.gmail.com" type="cite"> <div class="gmail_quote">On Thu, Dec 27, 2012 at 9:53 AM, julien2412 <<a moz-do-not-send="true" href="mailto:serval2412@yahoo.fr" target="_blank">serval2412@yahoo.fr</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hello, Cppcheck reports this kind of thing: [sd/source/filter/ppt/propread.hxx:116]: (style) 'PropEntry::operator=' should return 'PropEntry &'. 116 const PropEntry& operator=(const PropEntry& rPropEntry); Indeed, I understand this cppcheck report, if you assign a variable, the result can't be considered as "const". </blockquote> </div> Yes, the assignment operator should always return a non-const reference of self. Cppcheck is correct on this. Kohei </blockquote> Thank you Kohei for your feedback, I pushed 2 commits, see: <a class="moz-txt-link-freetext" href="https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=8068f50276659058ef02958996d8ef84cd89017f">https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=8068f50276659058ef02958996d8ef84cd89017f</a> <a class="moz-txt-link-freetext" href="https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=a1ff0ec108822d593bb293b6d37a34e6e7c012e5">https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=a1ff0ec108822d593bb293b6d37a34e6e7c012e5</a> But there are still these: [lingucomponent/source/languageguessing/simpleguesser.hxx:43]: (style) 'SimpleGuesser::operator=' should return 'SimpleGuesser &'. [reportdesign/source/filter/xml/xmlComponent.hxx:37]: (style) 'OXMLComponent::operator=' should return 'OXMLComponent &'. [reportdesign/source/filter/xml/xmlFunction.hxx:41]: (style) 'OXMLFunction::operator=' should return 'OXMLFunction &'. [reportdesign/source/filter/xml/xmlGroup.hxx:38]: (style) 'OXMLGroup::operator=' should return 'OXMLGroup &'. [reportdesign/source/filter/xml/xmlCell.hxx:41]: (style) 'OXMLCell::operator=' should return 'OXMLCell &'. All except first one, return an object instead of a ref to an object. I don't know if I can't just put "&" or if it should be investigated. First one isn't an assignment but a comparison! Isn't it a little dangerous? Julien </body> </html>