On Tue, 2013-02-12 at 05:58 -0800, julien2412 [via Document Foundation
<br/>Mail Archive] wrote:
<div class='shrinkable-quote'><br/>> Caolán McNamara wrote
<br/>> So, unless Rafael has other plans, it looks to me that you can
<br/>> remove the bContainsDate lines, the aDT = lines, and the
<br/>> getPropertyValue(..)
<br/>> >>= aDT block.
<br/>> I don't know if you received some information from Raphael but if we
<br/>> remove aDT variable, does it also mean this whole block can be
<br/>> removed?
<br/>>
<br/>> 147 if ( bHasTargetURL &&
<br/>> 148 INetURLObject( aContentURL
<br/>> ).GetProtocol() == INET_PROT_VND_SUN_STAR_HIER )
<br/>> 149 {
<br/>> 150 ucbhelper::Content aCnt( aTargetURL,
<br/>> m_xCmdEnv, comphelper::getProcessComponentContext() );
<br/>> 151
<br/>> 152 try
<br/>> 153 {
<br/>> 154
<br/>> aCnt.getPropertyValue("DateModified") >>= aDT;
<br/>> 155 }
<br/>> 156 catch (...)
<br/>> 157 {}
<br/>> 158 }
<br/>>
<br/>> or does the call to Content constructor initialize something that I
<br/>> missed
</div><br/>I heard nothing from Rafael and as far as I can see the whole block can
<br/>go, i.e. the ucbhelper::Content ctor has no side effects.
<br/><br/>C.
<br/><br/>
<br/><hr align="left" width="300" />
View this message in context: <a href="http://nabble.documentfoundation.org/Cppcheck-bContainsDate-not-read-in-templateremoteview-cxx-sfx2-tp4032416p4040331.html">Re: Cppcheck: "bContainsDate" not read in templateremoteview.cxx (sfx2)</a><br/>
Sent from the <a href="http://nabble.documentfoundation.org/Dev-f1639786.html">Dev mailing list archive</a> at Nabble.com.<br/>