<div dir="ltr">Building LO with this patch now. I will report my findings asap.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/4/9 Cao Cuong Ngo (via Code Review) <span dir="ltr"><<a href="mailto:gerrit@gerrit.libreoffice.org" target="_blank">gerrit@gerrit.libreoffice.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I have submitted a patch for review:<br>
<br>
<a href="https://gerrit.libreoffice.org/3285" target="_blank">https://gerrit.libreoffice.org/3285</a><br>
<br>
To pull it, you can do:<br>
<br>
git pull ssh://<a href="http://gerrit.libreoffice.org:29418/core" target="_blank">gerrit.libreoffice.org:29418/core</a> refs/changes/85/3285/1<br>
<br>
fdo#47018 fix Impress crash on modifying bullet<br>
<br>
Add verifying of numbering rule to avoid invalidated attribute<br>
<br>
Change-Id: Ifc3db3f09f9358d272245f1e00fad2802f5881ee<br>
---<br>
M sd/source/ui/func/fuolbull.cxx<br>
1 file changed, 11 insertions(+), 1 deletion(-)<br>
<br>
<br>
<br>
diff --git a/sd/source/ui/func/fuolbull.cxx b/sd/source/ui/func/fuolbull.cxx<br>
index ae29032..49fd245 100644<br>
--- a/sd/source/ui/func/fuolbull.cxx<br>
+++ b/sd/source/ui/func/fuolbull.cxx<br>
@@ -22,6 +22,7 @@<br>
#include <svl/intitem.hxx><br>
#include <editeng/outliner.hxx><br>
#include <editeng/eeitem.hxx><br>
+#include <editeng/numitem.hxx><br>
#include <sfx2/request.hxx><br>
<br>
#include <editeng/editdata.hxx><br>
@@ -64,7 +65,16 @@<br>
<br>
SfxItemSet aNewAttr( mpViewShell->GetPool(),<br>
EE_ITEMS_START, EE_ITEMS_END );<br>
- aNewAttr.Put( aEditAttr, sal_False );<br>
+<br>
+ // fdo#47018 verify numbering rule<br>
+ const SfxPoolItem* pItem;<br>
+ sal_uInt16 nWhich = aEditAttr.GetPool()->GetWhich(SID_ATTR_NUMBERING_RULE);<br>
+ aEditAttr.GetItemState(nWhich, sal_False, &pItem);<br>
+ const sal_uInt16 levelCount = (*((SvxNumBulletItem*)pItem)->GetNumRule()).GetLevelCount();<br>
+<br>
+ // check if the attribute is valid<br>
+ if ( levelCount )<br>
+ aNewAttr.Put( aEditAttr, sal_False );<br>
<br>
// create and execute dialog<br>
SdAbstractDialogFactory* pFact = SdAbstractDialogFactory::Create();<br>
<br>
--<br>
To view, visit <a href="https://gerrit.libreoffice.org/3285" target="_blank">https://gerrit.libreoffice.org/3285</a><br>
To unsubscribe, visit <a href="https://gerrit.libreoffice.org/settings" target="_blank">https://gerrit.libreoffice.org/settings</a><br>
<br>
Gerrit-MessageType: newchange<br>
Gerrit-Change-Id: Ifc3db3f09f9358d272245f1e00fad2802f5881ee<br>
Gerrit-PatchSet: 1<br>
Gerrit-Project: core<br>
Gerrit-Branch: master<br>
Gerrit-Owner: Cao Cuong Ngo <<a href="mailto:cao.cuong.ngo@gmail.com">cao.cuong.ngo@gmail.com</a>><br>
<br>
_______________________________________________<br>
LibreOffice mailing list<br>
<a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a><br>
</blockquote></div><br></div>