<div dir="ltr"><div><div><div>Hi, Cao, <br><br>Just checked your patch (Change-Id: I57d1245db650d12e6b2c05baece379038b673689) merged with:<br><br>Version: 4.1.0.0.alpha0+<br>Build ID: 0b897dd455968862e348de2c5e1c57d4d73640b<br>
<br></div>This patch indeed fixes all of the problems mentioned in fdo#47018, including the crash.<br><br></div>Brilliant. Thanks a lot, Cao!<br><br>AFAIK the patched code is used in Impress, but also in Calc and Draw. I'll be running this build at the office for a couple of days. I'll let you know if I notice any unwanted side effects in other use cases.<br>
</div><div><br></div>Greetings,<br><br>Stephan<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/4/12 Stephan van den Akker <span dir="ltr"><<a href="mailto:stephanv778@gmail.com" target="_blank">stephanv778@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Cao,<br><div><br>That sounds great!<br><br>Building LO now with your patch. Stay tuned....<br><br></div>
<div>Greetings,<br><br></div><div>Stephan<br></div><div><br><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">2013/4/12 Cao Cuong Ngo <span dir="ltr"><<a href="mailto:cao.cuong.ngo@gmail.com" target="_blank">cao.cuong.ngo@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div><br>
Hi Stephan,<br>
<br>
Thanks for taking the time to test it :-)<br>
<br>
I've made a new patch that fixes the crash and the copy/paste
action.<br>
<br>
You can try it here<br>
<pre><a href="https://gerrit.libreoffice.org/3352" target="_blank">https://gerrit.libreoffice.org/3352</a></pre>
Best,<br>
Cao Cuong Ngo<div><div><br>
<br>
On 04/09/2013 05:05 PM, Stephan van den Akker wrote:<br>
</div></div></div><div><div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>Just tested this patch, applied to:<br>
<br>
Version: 4.1.0.0.alpha0+<br>
Build ID: 2705fc72df2058332773b5cb04a6b4d207f5e39<br>
<br>
</div>
The proposed patch will prevent the crash, but it seems
that the underlying problem is not solved by this: <br>
The bullets do not survive the copy / paste action of the
EditEngineFormat: Copy/paste of bulletted text into an
already bulletted empty line still makes the bullet
disappear.<br>
<br>
</div>
So I would say that there is progress, but IMHO the patch
doesn't warrant the closing of fdo#47018.<br>
<br>
</div>
Greetings, and thanks for the good work.<br>
<br>
</div>
Stephan van den Akker<br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2013/4/9 Stephan van den Akker <span dir="ltr"><<a href="mailto:stephanv778@gmail.com" target="_blank">stephanv778@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Building LO with this patch now. I will
report my findings asap.<br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2013/4/9 Cao Cuong Ngo (via Code
Review) <span dir="ltr"><<a href="mailto:gerrit@gerrit.libreoffice.org" target="_blank">gerrit@gerrit.libreoffice.org</a>></span>
<div>
<div><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I have submitted a patch for review:<br>
<br>
<a href="https://gerrit.libreoffice.org/3285" target="_blank">https://gerrit.libreoffice.org/3285</a><br>
<br>
To pull it, you can do:<br>
<br>
git pull ssh://<a href="http://gerrit.libreoffice.org:29418/core" target="_blank">gerrit.libreoffice.org:29418/core</a>
refs/changes/85/3285/1<br>
<br>
fdo#47018 fix Impress crash on modifying bullet<br>
<br>
Add verifying of numbering rule to avoid
invalidated attribute<br>
<br>
Change-Id:
Ifc3db3f09f9358d272245f1e00fad2802f5881ee<br>
---<br>
M sd/source/ui/func/fuolbull.cxx<br>
1 file changed, 11 insertions(+), 1 deletion(-)<br>
<br>
<br>
<br>
diff --git a/sd/source/ui/func/fuolbull.cxx
b/sd/source/ui/func/fuolbull.cxx<br>
index ae29032..49fd245 100644<br>
--- a/sd/source/ui/func/fuolbull.cxx<br>
+++ b/sd/source/ui/func/fuolbull.cxx<br>
@@ -22,6 +22,7 @@<br>
#include <svl/intitem.hxx><br>
#include <editeng/outliner.hxx><br>
#include <editeng/eeitem.hxx><br>
+#include <editeng/numitem.hxx><br>
#include <sfx2/request.hxx><br>
<br>
#include <editeng/editdata.hxx><br>
@@ -64,7 +65,16 @@<br>
<br>
SfxItemSet aNewAttr(
mpViewShell->GetPool(),<br>
EE_ITEMS_START,
EE_ITEMS_END );<br>
- aNewAttr.Put( aEditAttr, sal_False );<br>
+<br>
+ // fdo#47018 verify numbering rule<br>
+ const SfxPoolItem* pItem;<br>
+ sal_uInt16 nWhich =
aEditAttr.GetPool()->GetWhich(SID_ATTR_NUMBERING_RULE);<br>
+ aEditAttr.GetItemState(nWhich, sal_False,
&pItem);<br>
+ const sal_uInt16 levelCount =
(*((SvxNumBulletItem*)pItem)->GetNumRule()).GetLevelCount();<br>
+<br>
+ // check if the attribute is valid<br>
+ if ( levelCount )<br>
+ aNewAttr.Put( aEditAttr, sal_False );<br>
<br>
// create and execute dialog<br>
SdAbstractDialogFactory* pFact =
SdAbstractDialogFactory::Create();<br>
<br>
--<br>
To view, visit <a href="https://gerrit.libreoffice.org/3285" target="_blank">https://gerrit.libreoffice.org/3285</a><br>
To unsubscribe, visit <a href="https://gerrit.libreoffice.org/settings" target="_blank">https://gerrit.libreoffice.org/settings</a><br>
<br>
Gerrit-MessageType: newchange<br>
Gerrit-Change-Id:
Ifc3db3f09f9358d272245f1e00fad2802f5881ee<br>
Gerrit-PatchSet: 1<br>
Gerrit-Project: core<br>
Gerrit-Branch: master<br>
Gerrit-Owner: Cao Cuong Ngo <<a href="mailto:cao.cuong.ngo@gmail.com" target="_blank">cao.cuong.ngo@gmail.com</a>><br>
<br>
_______________________________________________<br>
LibreOffice mailing list<br>
<a href="mailto:LibreOffice@lists.freedesktop.org" target="_blank">LibreOffice@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a><br>
</blockquote>
</div>
</div>
</div>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>