<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Janit,<br>
<br>
I see your patches keeps passing by. Sending your patch by email
is not wrong, but we have another handy tool to review/comment/...
patches -> Gerrit.<br>
<br>
Please have a look at
<a class="moz-txt-link-freetext" href="https://wiki.documentfoundation.org/Development/gerrit#Setting_Yourself_Up_For_Gerrit">https://wiki.documentfoundation.org/Development/gerrit#Setting_Yourself_Up_For_Gerrit</a>
so you can send them that way. I think that's a lot easier for
developers to review and leave comments.<br>
<br>
Just my 0,02€ (please be aware of the currency exchange ;-) )<br>
<br>
Kind regards,<br>
Joren<br>
<br>
Op 16-04-13 20:30, Janit Anjaria schreef:<br>
</div>
<blockquote
cite="mid:CAFrS=rfJk-k4Ze3wiCtx7O2-njBCNqdqex-76i9tB3X1YhrUqQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>Hey!<br>
<br>
</div>
I am hereby attaching my patch for fdo #62096 :<br>
<br>
<a moz-do-not-send="true"
href="https://bugs.freedesktop.org/show_bug.cgi?id=62096"
target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=62096</a><br>
<br>
</div>
Any suggestions would be great to be implemented.<br>
<br>
</div>
Regards,<br>
</div>
Janit
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Apr 16, 2013 at 11:52 PM,
Janit Anjaria <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:janit92@gmail.com" target="_blank">janit92@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>
<div>
<div>
<div>Hey Stephan!<br>
</div>
I think that was due to hurry(the things for "!="
things)...and yeah i dont know ,i overlooked the
build and hence i suppose the thing you just
mentioned about child_process.cxx is one of those
rotten tests.<br>
<br>
</div>
And yes,ill surely look into the matter with
identation(i generally do take care of it,but
because of a lil hurry as i am also working on the
project -i had mailed on the list simultaneously
...so swamped with too much of code ! :P )<br>
<br>
</div>
<div>Hope this finds you in good health.<br>
<br>
</div>
Regards,<br>
</div>
Janit<br>
</div>
<div>
<div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Tue, Apr 16, 2013 at
6:30 PM, Stephan Bergmann <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:sbergman@redhat.com"
target="_blank">sbergman@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px
0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>On 04/15/2013 03:19 PM, Janit Anjaria
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
I am hereby attaching my patch for fdo
#62096 :<br>
<br>
<a moz-do-not-send="true"
href="https://bugs.freedesktop.org/show_bug.cgi?id=62096"
target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=62096</a><br>
<br>
Any suggestions would be great to be
implemented.<br>
</blockquote>
<br>
</div>
First, note that<br>
<br>
s.compareTo(t) != 0<br>
<br>
is /not/ the same as<br>
<br>
s == t<br>
<br>
Second, did you build and test your change? It
looks like sal/qa/rtl/process/child_process.cxx
is one of those rotting tests that is not built
nor executed, not even with a top-level "make
check".<br>
<br>
Also, please take care not to mess up the
indentation of lines, making the "if" indented
only three instead of four spaces.<span><font
color="#888888"><br>
<br>
Stephan<br>
</font></span></blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
LibreOffice mailing list
<a class="moz-txt-link-abbreviated" href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/libreoffice">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a>
</pre>
</blockquote>
<br>
</body>
</html>