<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1>Hi,<o:p></o:p>I have prepared a document in Word that has a page-border (with no shadow). <o:p></o:p>I've saved it as a DOC and DOCX that are the same (attached).<o:p></o:p><o:p> </o:p>The document has:<o:p></o:p><![if !supportLists]>· <![endif]>Page margin of 72pt (1440 TWIP) <o:p></o:p><![if !supportLists]>· <![endif]>Page border 0.5pt thick (10 TWIP)<o:p></o:p><![if !supportLists]>· <![endif]>Border is at a distance of 5pt (100 TWIP) from the text.<o:p></o:p><o:p> </o:p><img width=960 height=401 id="Picture_x0020_3" src="cid:image001.jpg@01CE62D1.1464F290"><o:p></o:p><o:p> </o:p>When I import both DOC and DOCX in LO – they look different and are exported differently to DOCX.<o:p></o:p>When I dived into the code – I first looked at the DOCX exporter to try to understand what is different.<o:p></o:p>I found out that in this function - <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx#4387">DocxAttributeOutput::FormatLRSpace</a> – in <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx#4417">line 4417</a> this happens: <o:p></o:p><pre style='background:white'> <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx#nLDist">nLDist</a> = <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx#nLDist">nLDist</a> + (<a href="http://opengrok.libreoffice.org/s?defs=sal_uInt16&project=core">sal_uInt16</a>)<a href="http://opengrok.libreoffice.org/s?defs=rLRSpace&project=core">rLRSpace</a>.<a href="http://opengrok.libreoffice.org/s?defs=GetLeft&project=core">GetLeft</a>();<o:p></o:p></pre><pre style='background:white'> <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx#nRDist">nRDist</a> = <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx#nRDist">nRDist</a> + (<a href="http://opengrok.libreoffice.org/s?defs=sal_uInt16&project=core">sal_uInt16</a>)<a href="http://opengrok.libreoffice.org/s?defs=rLRSpace&project=core">rLRSpace</a>.<a href="http://opengrok.libreoffice.org/s?defs=GetRight&project=core">GetRight</a>();<o:p></o:p></pre><pre style='background:white'><o:p> </o:p></pre><pre style='background:white'><o:p> </o:p></pre><pre style='line-height:150%;background:white'>When I debugged it I saw that <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx#nLDist">nLDist</a> and <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx#nRDist">nRDist</a> are 110 (both the same when importing DOC and when importing DOCX). <o:p></o:p></pre><pre style='line-height:150%;background:white'>I guess 110 = border thickness + border distance from text.<o:p></o:p></pre><pre style='line-height:150%;background:white'><o:p> </o:p></pre><pre style='line-height:150%;background:white'>However, there is a difference between DOC and DOCX that were imported on the right hand-side parameter:<o:p></o:p></pre><pre style='margin-left:.5in;text-indent:-.25in;line-height:150%;mso-list:l1 level1 lfo1;background:white'><![if !supportLists]>· <![endif]>When I import from DOC – the <a href="http://opengrok.libreoffice.org/s?defs=rLRSpace&project=core">rLRSpace</a>.<a href="http://opengrok.libreoffice.org/s?defs=GetLeft&project=core">GetLeft</a>()returns 1330, which is the original 1440 minus 110 (in TIPS it is 72 – 5.5)<o:p></o:p></pre><pre style='margin-left:.5in;text-indent:-.25in;line-height:150%;mso-list:l1 level1 lfo1;background:white'><![if !supportLists]>· <![endif]>When I import from DOCX – the <a href="http://opengrok.libreoffice.org/s?defs=rLRSpace&project=core">rLRSpace</a>.<a href="http://opengrok.libreoffice.org/s?defs=GetLeft&project=core">GetLeft</a>()returns 1440.<o:p></o:p></pre><pre style='line-height:150%;background:white'><o:p> </o:p></pre><pre style='line-height:150%;background:white'>This lead me to think that the import process is faulted, and that:<o:p></o:p></pre><pre style='margin-left:.5in;text-indent:-.25in;line-height:150%;mso-list:l1 level1 lfo1;background:white'><![if !supportLists]>· <![endif]>When importing from DOC – the (border+border margin) are deducted from the page margin<o:p></o:p></pre><pre style='margin-left:.5in;text-indent:-.25in;line-height:150%;mso-list:l1 level1 lfo1;background:white'><![if !supportLists]>· <![endif]>When importing from DOCX – this is not deducted<o:p></o:p></pre><pre style='line-height:150%;background:white'><o:p> </o:p></pre><pre style='line-height:150%;background:white'>This leads to the fact that when I export to DOCX than:<o:p></o:p></pre><pre style='margin-left:.5in;text-indent:-.25in;line-height:150%;mso-list:l1 level1 lfo1;background:white'><![if !supportLists]>· <![endif]>When the imported file was a DOC – the exported page margin is 1440 (110 + 1330)<o:p></o:p></pre><pre style='margin-left:.5in;text-indent:-.25in;line-height:150%;mso-list:l1 level1 lfo1;background:white'><![if !supportLists]>· <![endif]>When the imported file was a DOC – the exported page margin is 1550 (110 + 1440)<o:p></o:p></pre><pre style='background:white'><o:p> </o:p></pre>I have located an interesting code piece in the DOC importer, that seems to deduct the '110 TWIPs' from the '1440' when importing,<o:p></o:p>In the function <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/ww8par6.cxx#449">SetPageBorder</a> that calls <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/ww8par6.cxx#SetFlyBordersShadow">SetFlyBordersShadow</a>.<o:p></o:p>This <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/ww8par6.cxx#SetFlyBordersShadow">SetFlyBordersShadow</a> seems to initialize an 'aSizeArray' that is then <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/ww8par6.cxx#495">deducted</a> from the page margins.<o:p></o:p><o:p> </o:p>The same logic does not appear to exist in the <a href="http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/PropertyMap.cxx#SetBorderDistance">equivalent function</a> in the DOCX importer.<o:p></o:p><o:p> </o:p>Simply adding the logic of <a href="http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/ww8par6.cxx#SetFlyBordersShadow">SetFlyBordersShadow</a> to the DOCX importer looks very complicated to me (requires implementing a lot of functions from ww8, not trivial for me).<o:p></o:p><o:p> </o:p>Before I even think of doing that – I'd like to hear if anyone thinks of a better solution to the problem (maybe I am understanding things wrong).<o:p></o:p><o:p> </o:p>Best,<o:p></o:p> Adam Co<o:p></o:p></div></body></html>