<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"><meta name="Generator" content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
        {font-family:Helvetica;
        panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:Tahoma;
        panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        margin-bottom:.0001pt;
        line-height:150%;
        font-size:12.0pt;
        font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:#0563C1;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:#954F72;
        text-decoration:underline;}
span.EmailStyle17
        {mso-style-type:personal-compose;
        font-family:"Calibri","sans-serif";
        color:#1F497D;}
.MsoChpDefault
        {mso-style-type:export-only;}
.MsoPapDefault
        {mso-style-type:export-only;
        line-height:150%;}
@page WordSection1
        {size:8.5in 11.0in;
        margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
        {page:WordSection1;}
--></style></head><body lang="EN-US" link="#0563C1" vlink="#954F72"><div class="WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">Hi,</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">There is a bug I am trying to fix regarding line numbering.</span></p><p class="MsoNormal">
<span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">In Word, a line numbering node typically looks like this:</span></p><p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d"><img width="548" height="140" id="Picture_x0020_1" src="cid:image003.jpg@01CE7731.02197A10"></span><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d"></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">It seems like the DOCX importer does not make use of the imported 'w:start' attribute (it is imported <a href="http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/DomainMapper.cxx#1380">here</a>).</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">What I saw was that in the function "<a href="http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/PropertyMap.cxx#830">PropertyMap::CloseSectionGroup</a>" there is a check if "m_nLnnMod" is set.</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">The function also looks at "m_nLnnMin" when setting the "PROP_PARA_LINE_NUMBER_START_VALUE".</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">However, this "m_nLnnMin" is set in only when the parser reads the <a href="http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/DomainMapper.cxx#2537">NS_sprm::LN_SLnnMin</a> value.</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">In addition, the "m_nLnnMod" is set only when the parser reads the <a href="http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/DomainMapper.cxx#2519">NS_sprm::LN_SNLnnMod</a> value.</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">Am I correct to assume that these values are read only in the DOC importer, and not in the DOCX importer?</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">Is it true to say that DOCX attributes are always 'NS_ooxml::….' ?</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">If I am correct – when I parse the 'start value' in the relevant '<a href="http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/DomainMapper.cxx#1380">NS_ooxml::LN_CT_LineNumber_start</a>' node, should I simply mimick the behavior of the 'NS_sprm::LN_SLnnMin' parsing?</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d">Best,</span></p>
<p class="MsoNormal" style="text-indent:.5in"><b><span style="font-size:10.0pt;line-height:150%;font-family:"Tahoma","sans-serif";color:#215868">Adam Fyne</span></b></p><p class="MsoNormal" style="text-indent:.5in">
<b><span style="font-size:8.5pt;line-height:150%;font-family:"Tahoma","sans-serif";color:#666666">Office:</span></b><span style="font-size:10.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:#666666"> </span><span style="font-size:8.5pt;line-height:150%;font-family:"Tahoma","sans-serif";color:#666666">+972-77-517-5008</span></p>
<p class="MsoNormal" style="text-indent:.5in"><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d"><a href="http://www.twitter.com/cloudoninc" target="_blank"><span style="font-size:10.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:#96c240">Twitter</span></a></span><span style="font-size:11.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:black"> </span><span style="font-size:10.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:#666666">|</span><span style="font-size:11.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:black"> </span><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d"><a href="http://www.linkedin.com/company/cloudon" target="_blank"><span style="font-size:10.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:#96c240">LinkedIn</span></a></span><span style="font-size:10.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:#666666"> |</span><span style="font-size:11.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:black"> </span><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d"><a href="http://www.facebook.com/cloudoninc" target="_blank"><span style="font-size:10.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:#96c240">Facebook</span></a></span><span style="font-size:11.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:black"> </span><span style="font-size:10.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:#666666">|</span><span style="font-size:11.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:black"> </span><span style="font-size:11.0pt;line-height:150%;font-family:"Calibri","sans-serif";color:#1f497d"><a href="http://www.cloudon.com/" target="_blank"><span style="font-size:10.0pt;line-height:150%;font-family:"Helvetica","sans-serif";color:#96c240">Blog</span></a></span></p>
<p class="MsoNormal"> </p></div></body></html>