<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:lohmaier@gmx.de" title="Christian Lohmaier <lohmaier@gmx.de>"> <span class="fn">Christian Lohmaier</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - sign windows binaries during build"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=63315">bug 63315</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>lohmaier@gmx.de
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - sign windows binaries during build"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=63315#c2">Comment # 2</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - sign windows binaries during build"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=63315">bug 63315</a>
              from <span class="vcard"><a class="email" href="mailto:lohmaier@gmx.de" title="Christian Lohmaier <lohmaier@gmx.de>"> <span class="fn">Christian Lohmaier</span></a>
</span></b>
        <pre>This one has been fixed already.
(signing the msi during the build was an extra step, but
<a href="http://cgit.freedesktop.org/libreoffice/core/commit/?id=125769a4a15cf6f4b9ef9d0e757ac55bd9e26509">http://cgit.freedesktop.org/libreoffice/core/commit/?id=125769a4a15cf6f4b9ef9d0e757ac55bd9e26509</a>
made that part of the build)


Now for signing the dlls right after they are created: I don't think this is a
good idea, in fact IMHO it is a rather bad idea.

Creating processes in windows is slow as fu^Whell, so anything that can be
grouped into one invocation, should be grouped into one invocation.

The build is already slowed down so much by all those "I built a file, so I
need to touch a marker-file" stuff and copying every bit individually instead
of copying whole directory trees...</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>