<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Adapt supportsService implementations to cppu::supportsService"
href="https://bugs.freedesktop.org/show_bug.cgi?id=54938#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Adapt supportsService implementations to cppu::supportsService"
href="https://bugs.freedesktop.org/show_bug.cgi?id=54938">bug 54938</a>
from <span class="vcard"><a class="email" href="mailto:sbergman@redhat.com" title="Stephan Bergmann <sbergman@redhat.com>"> <span class="fn">Stephan Bergmann</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=54938#c5">comment #5</a>)
<span class="quote">> In reportdesign, I saw a lot of uses of comhelper::existsValue:
>
> ::sal_Bool SAL_CALL OToolboxController::supportsService( const OUString&
> ServiceName ) throw (uno::RuntimeException)
> {
> return
> ::comphelper::existsValue(ServiceName,getSupportedServiceNames_Static());
> }
>
> We want to remove this too and use cppuhelper::supportsService?</span >
Yes, I would suggest to rewrite those supportsService member functions to use
cppuhelper::supportsService, for the sake of consistency.
(In reply to <a href="show_bug.cgi?id=54938#c6">comment #6</a>)
<span class="quote">> sal_Bool SAL_CALL ServiceInfoHelper::supportsService( const OUString&
> ServiceName, const ::com::sun::star::uno::Sequence< OUString >&
> SupportedServices ) throw()
> {
> const OUString * pArray = SupportedServices.getConstArray();
> for( sal_Int32 i = 0; i < SupportedServices.getLength(); i++ )
> if( pArray[i] == ServiceName )
> return sal_True;
> return sal_False;
> }
>
> Maybe we want to remove this too?</span >
Yes, the static comphelper::ServiceInfoHelper::supportsService can go.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>