<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally"
href="https://bugs.freedesktop.org/show_bug.cgi?id=72606">72606</a>
</td>
</tr>
<tr>
<th>CC</th>
<td>jesus@softcatala.org, libreoffice@lists.freedesktop.org, thomas-libo@arnhold.org, tml@iki.fi
</td>
</tr>
<tr>
<th>Assignee</th>
<td>libreoffice-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Summary</th>
<td>[EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>OS</th>
<td>Windows (All)
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mstahl@redhat.com
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Version</th>
<td>4.3.0.0.alpha0+ Master
</td>
</tr>
<tr>
<th>Component</th>
<td>Libreoffice
</td>
</tr>
<tr>
<th>Product</th>
<td>LibreOffice
</td>
</tr></table>
<p>
<div>
<pre>currently there are lots of places where manually macros
UNICODE and _UNICODE are defined:
<a href="http://blogs.msdn.com/b/oldnewthing/archive/2004/02/12/71851.aspx">http://blogs.msdn.com/b/oldnewthing/archive/2004/02/12/71851.aspx</a>
git grep DUNICODE
git grep D_UNICODE
we should rather define that globally in solenv/gbuild/com_MSC_defs.mk.
also there is no point to ever calling the archaic so-called "ANSI"
Win32 functions (end in *A); probably it's best to call the
UCS-2 Unicode ones directly (end in *W).
corresponding string literals can be written as L"foo"
maybe once every function call is directly to a *W function
the UNICODE _UNICODE can be removed altogether, but as a first
step it's probably best to define that globally.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>